Skip to content

Commit

Permalink
buildstatus should only show steps that have started.
Browse files Browse the repository at this point in the history
The recent setStepStarted() change causes some steps
to have text set when they're created.  In those cases,
buildstatus would show the step even though it may not
have started yet.  This change causes buildstatus to
only show steps that have started.
  • Loading branch information
chasephillips committed Feb 17, 2010
1 parent 20e1bf1 commit 10b9863
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions buildbot/status/web/buildstatus.py
Expand Up @@ -33,8 +33,9 @@ def content(self, request, ctx):

# Display each step, starting by the last one.
for i in range(len(build.getSteps()) - 1, -1, -1):
if build.getSteps()[i].getText():
rows.append(IBox(build.getSteps()[i]).getBox(request).td(align="center"))
step = build.getSteps()[i]
if step.isStarted() and step.getText():
rows.append(IBox(step).getBox(request).td(align="center"))

# Display the bottom box with the build number in it.
ctx['build'] = IBox(build).getBox(request).td(align="center")
Expand Down

0 comments on commit 10b9863

Please sign in to comment.