Skip to content

Commit

Permalink
Fix issue with perforce submissions with no comment.
Browse files Browse the repository at this point in the history
This currently causes p4poller to throw an exception, which hangs further buildbot builds on that branch.
Now blank comments are allowed.
  • Loading branch information
bdbaddog committed Dec 11, 2009
1 parent acb279a commit 1c8c37d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion buildbot/changes/p4poller.py
Expand Up @@ -31,7 +31,7 @@ class P4Source(base.ChangeSource, util.ComparableMixin):
"p4bin", "pollinterval"]

changes_line_re = re.compile(
r"Change (?P<num>\d+) on \S+ by \S+@\S+ '.+'$")
r"Change (?P<num>\d+) on \S+ by \S+@\S+ '.*'$")
describe_header_re = re.compile(
r"Change \d+ by (?P<who>\S+)@\S+ on (?P<when>.+)$")
file_re = re.compile(r"^\.\.\. (?P<path>[^#]+)#\d+ \w+$")
Expand Down

0 comments on commit 1c8c37d

Please sign in to comment.