Merge branch 'pylint' of git://github.com/maruel/buildbot

* 'pylint' of git://github.com/maruel/buildbot:
  Add pylintrc to reduce the number of useless warnings.

buildbot/interfaces.py

@@ -2,6 +2,9 @@
 
 Define the interfaces that are implemented by various buildbot classes.
 """
+# E0211: Method has no argument
+# E0213: Method should have "self" as first argument
+# pylint: disable-msg=E0211,E0213
 
 from zope.interface import Interface, Attribute
 

pylintrc

@@ -0,0 +1,64 @@
+# Buildbot pylint configuration file
+#
+# Severely strips pylint output to expose more important issues. As fixes goes
+# in, it will make sense to re-enable some of these messages.
+
+[MESSAGES CONTROL]
+# List of all available ids: http://www.logilab.org/card/pylintfeatures
+
+# Disabled messages:
+# C0103: Invalid name "xxx" (should match [a-z_][a-z0-9_]{2,30}$)
+# C0111: Missing docstring
+# C0301: Line too long (NN/80)
+# C0302: Too many lines in module (%s) Used when a module has too much lines,
+# reducing its readibility.
+# I0011: Locally disabling %s Used when an inline option disable a message or a
+# messages category.
+# R0201: Method could be a function. Used when a method doesn't use its bound
+# instance, and so could be written as a function.
+# R0801: Similar lines in %s files. Indicates that a set of similar lines has
+# been detected among multiple file. This usually means that the code should be
+# refactored to avoid this duplication.
+# R0902: Too many instance attributes (N/7)
+# R0903: Too few public methods (N/2)
+# R0904: Too many public methods (N/20)
+# R0912: Too many branches (N/12)
+# R0913: Too many arguments (N/5)
+# R0914: Too many local variables (N/15)
+# W0102: Dangerous default value %s as argument Used when a mutable value as
+# list or dictionary  is detected in a default value for an argument.
+# W0142: Used * or * magic* Used when a function or method is called using *args
+# or **kwargs to dispatch arguments. This doesn't improve readility and should
+# be used with care.
+# W0212: Access to a protected member %s of a client class Used when a protected
+# member  (i.e. class member with a name beginning with an underscore) is access
+# outside the class or a descendant of the class where it's defined.
+# W0232: Class has no __init__ method Used when a class has no __init__ method,
+# neither its parent classes.
+# W0511: TODO
+# W0602: Using global for %r but no assigment is done Used when a variable is
+# defined through  the "global" statement but no assigment to this variable is
+# done.
+# W0603: Using the global statement Used when you use the "global" statement to
+# update a global variable. PyLint just try to discourage this usage. That
+# doesn't mean  you can not use it !
+# W0622: Redefining built-in %r Used when a variable or function override a
+# built-in.
+# W0704: Except doesn't do anything Used when an except clause does nothing but
+# "pass" and there is no "else" clause.
+disable-msg=C0103,C0111,C0301,C0302,I0011,R0201,R0801,R0902,R0903,R0904,R0912,R0913,R0914,W0102,W0142,W0212,W0232,W0511,W0602,W0603,W0622,W0704
+
+[REPORTS]
+# Include message's id in output
+include-ids=yes
+
+# R0001: Messages by category
+# R0002: % errors / warnings by module
+# R0003: Messages
+# R0004: Global evaluation
+# R0101: Statistics by type
+# R0401: External dependencies
+# R0402: Modules dependencies graph
+# R0701: Raw metrics
+# R0801: Duplication
+disable-report=R0001,R0002,R0003,R0004,R0101,R0401,R0402,R0701,R0801