Skip to content

Commit

Permalink
remove overzealous escaping of reason in rebuild()
Browse files Browse the repository at this point in the history
I'd like a second look at this, since these escapes were added while
resolving the XSS vulnerabilities back in 0.7.*.  I think they are
unnecessary, particularly with the use of Jinja.  I suspect they were
added out of an abundance of caution, lest the reason later be used
unescaped in a status display.
  • Loading branch information
Dustin J. Mitchell committed Mar 12, 2010
1 parent 0fc61b8 commit 21296a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion buildbot/status/web/build.py
Expand Up @@ -170,7 +170,7 @@ def rebuild(self, req):
name = req.args.get("username", ["<unknown>"])[0]
comments = req.args.get("comments", ["<no reason specified>"])[0]
reason = ("The web-page 'rebuild' button was pressed by "
"'%s': %s\n" % (html.escape(name), html.escape(comments)))
"'%s': %s\n" % (name, comments))
extraProperties = getAndCheckProperties(req)
if not bc or not b.isFinished() or extraProperties is None:
log.msg("could not rebuild: bc=%s, isFinished=%s"
Expand Down

1 comment on commit 21296a7

@marcus-sonestedt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.