Skip to content

Commit

Permalink
Reduce verbosity in twistd.log on the try server.
Browse files Browse the repository at this point in the history
Remove the patch from the 'patch' argument when logging.

from http://src.chromium.org/viewvc/chrome?view=rev&revision=45608
fixes buildbot#803
  • Loading branch information
Dustin J. Mitchell committed May 27, 2010
1 parent 5ff4d18 commit 470da74
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion buildbot/process/buildstep.py
Expand Up @@ -1012,7 +1012,17 @@ def startCommand(self, cmd, errorMessages=[]):
all output being put into our self.stdio_log LogFile
"""
log.msg("ShellCommand.startCommand(cmd=%s)" % (cmd,))
log.msg(" cmd.args = %r" % (cmd.args))
args = cmd.args
if "patch" in cmd.args:
# Don't print the patch in the logs, it's often too large and not
# useful.
args = cmd.args.copy()
# This is usually a tuple so convert it to a list to be able to modify
# it.
patch = list(args['patch'][:])
patch[1] = "(%s bytes)" % len(patch[1])
args['patch'] = patch
log.msg(" cmd.args = %r" % (args))
self.cmd = cmd # so we can interrupt it
self.step_status.setText(self.describe(False))

Expand Down

0 comments on commit 470da74

Please sign in to comment.