Skip to content

Commit

Permalink
Add new sqlite3 dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
krajaratnam committed Feb 15, 2010
1 parent d7dcf3e commit 641fea4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions README
Expand Up @@ -55,6 +55,11 @@ REQUIREMENTS:
Buildbot requires python-2.4 or later. It is also tested against
python-2.5 and python-2.6.

sqlite3: http://pypi.python.org/pypi/pysqlite

sqlite3 is required for python-2.4 and earlier (already included
in python-2.5 and later)

simplejson: http://pypi.python.org/pypi/simplejson

simplejson is required for python-2.5 and earlier (already included
Expand Down
3 changes: 3 additions & 0 deletions setup.py
Expand Up @@ -246,6 +246,9 @@ def finalize_options(self):
'twisted >= 2.0.0',
'Jinja2',
]
# Python-2.5 and up includes sqlite3
if not py_25:
setup_args['install_requires'].append('sqlite3')
# Python-2.6 and up includes json
if not py_26:
setup_args['install_requires'].append('simplejson')
Expand Down

2 comments on commit 641fea4

@catlee
Copy link

@catlee catlee commented on 641fea4 Feb 15, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 'if not py_25 and not py26' instead?

@djmitche
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py_25 means "2.5 or higher", so this was correct except for the wrong dependency name. I just committed a fix.

Please sign in to comment.