Skip to content

Commit

Permalink
Add sane default for MTR buildstep's warningPattern.
Browse files Browse the repository at this point in the history
The default warningPattern now matches when mysql-test-run detects
that a test case succeeds, but does not properly clean up the
environment for the following test. This is much better than getting
random warnings when a test case name or output contains the word
"warning" :-)
  • Loading branch information
Kristian Nielsen committed Oct 2, 2009
1 parent 9bd4602 commit 72b0abc
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions buildbot/process/mtrlogobserver.py
Expand Up @@ -250,7 +250,9 @@ class MTR(Test):

def __init__(self, dbpool=None, test_type="mysql-test-run", test_info="",
autoCreateTables=False, textLimit=5, testNameLimit=16,
parallel=4, logfiles = {}, lazylogfiles = True, **kwargs):
parallel=4, logfiles = {}, lazylogfiles = True,
warningPattern="MTR's internal check of the test case '.*' failed",
**kwargs):

# Add mysql server logfiles.
for mtr in range(0, parallel+1):
Expand All @@ -262,7 +264,8 @@ def __init__(self, dbpool=None, test_type="mysql-test-run", test_info="",
logname = "mysqld.%d.err.%d" % (mysqld, mtr)
filename = "mysql-test/var/%d/log/mysqld.%d.err" % (mtr, mysqld)
logfiles[logname] = filename
Test.__init__(self, logfiles=logfiles, lazylogfiles=lazylogfiles, **kwargs)
Test.__init__(self, logfiles=logfiles, lazylogfiles=lazylogfiles,
warningPattern=warningPattern, **kwargs)
self.dbpool = dbpool
self.test_type = test_type
self.test_info = test_info
Expand Down

0 comments on commit 72b0abc

Please sign in to comment.