Log errors from updateAllSlaves, but don't die on them

Fixes: buildbot#737
djmitche · Apr 9, 2010 · 808613a · 808613a
1 parent 78d538c
commit 808613a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/buildbot/master.py b/buildbot/master.py
@@ -245,7 +245,11 @@ def _add(ign):
 
     def _updateAllSlaves(self):
         """Notify all buildslaves about changes in their Builders."""
-        dl = [s.updateSlave() for s in self.slaves.values()]
+        dl = []
+        for s in self.slaves.values():
+            d = s.updateSlave()
+            d.addErrback(log.err)
+            dl.append(d)
         return defer.DeferredList(dl)
 
     def shouldMergeRequests(self, builder, req1, req2):