Merge branch 'changes' of git://github.com/chasephillips/buildbot

* 'changes' of git://github.com/chasephillips/buildbot:
  Add changeAdded status notifications.

buildbot/interfaces.py

@@ -935,6 +935,10 @@ def buildETAUpdate(build, ETA):
         """This is a periodic update on the progress this Build has made
         towards completion."""
 
+    def changeAdded(change):
+        """A new Change was added to the ChangeMaster.  By the time this event
+        is received, all schedulers have already received the change."""
+
     def stepStarted(build, step):
         """A step has just started. 'step' is the IBuildStepStatus which
         represents the step: it can be queried for more information.

buildbot/master.py

@@ -989,6 +989,7 @@ def addNewOnes(res):
     def addChange(self, change):
         for s in self.allSchedulers():
             s.addChange(change)
+        self.status.changeAdded(change)
 
     def submitBuildSet(self, bs):
         # determine the set of Builders to use

buildbot/status/base.py

@@ -29,6 +29,9 @@ def buildStarted(self, builderName, build):
     def buildETAUpdate(self, build, ETA):
         pass
 
+    def changeAdded(self, change):
+        pass
+
     def stepStarted(self, build, step):
         pass
 

buildbot/status/builder.py

@@ -2377,3 +2377,7 @@ def buildsetSubmitted(self, bss):
         bss.waitUntilFinished().addCallback(self.activeBuildSets.remove)
         for t in self.watchers:
             t.buildsetSubmitted(bss)
+
+    def changeAdded(self, change):
+        for t in self.watchers:
+            t.changeAdded(change)

buildbot/test/runs/test_status.py

@@ -1056,6 +1056,9 @@ def buildStarted(self, name, build):
     def buildETAUpdate(self, build, ETA):
         self.events.append(("buildETAUpdate", build, ETA))
         self.announce()
+    def changeAdded(self, change):
+        self.events.append(("changeAdded", change))
+        self.announce()
     def stepStarted(self, build, step):
         self.events.append(("stepStarted", build, step))
         self.announce()
@@ -1090,6 +1093,23 @@ def builderRemoved(self, name):
         self.events.append(("builderRemoved", name))
         self.announce()
 
+class VerifyChangeAdded(RunMixin, unittest.TestCase):
+    def testChangeAdded(self):
+        m = self.master
+
+        s = m.getStatus()
+        self.t1 = t1 = STarget(["builder"])
+        s.subscribe(t1)
+
+        m.loadConfig(config_2)
+        m.readConfig = True
+        m.startService()
+
+        cm = self.master.change_svc
+        c = Change("bob", ["Makefile", "foo/bar.c"], "changed stuff")
+        cm.addChange(c)
+        self.failUnlessEqual(t1.events[-1], ("changeAdded", c))
+
 class Subscription(RunMixin, unittest.TestCase):
     # verify that StatusTargets can subscribe/unsubscribe properly