Skip to content

Commit

Permalink
Removing useless conversion to int
Browse files Browse the repository at this point in the history
This simple comparison between revisions uses a conversion to int that breaks if the revision is not an int (like in Git). There's no difference simply comparing the strings directly, so I removed this.
  • Loading branch information
abyx committed Dec 22, 2009
1 parent 2835d4c commit 98f39c1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions buildbot/status/web/console.py
Expand Up @@ -204,8 +204,8 @@ def getAllChanges(self, source, status, debugInfo):
prevChange = None
newChanges = []
for change in allChanges:
rev = int(change.revision)
if not prevChange or rev != int(prevChange.revision):
rev = change.revision
if not prevChange or rev != prevChange.revision:
newChanges.append(change)
prevChange = change
allChanges = newChanges
Expand Down

0 comments on commit 98f39c1

Please sign in to comment.