Skip to content

Commit

Permalink
(refs buildbot#691) don't use chagnes in the customHTMLMailMessage fo…
Browse files Browse the repository at this point in the history
…r the moment
  • Loading branch information
Dustin J. Mitchell committed Jan 22, 2010
1 parent 17225c3 commit a119a02
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions buildbot/test/test_status.py
Expand Up @@ -164,9 +164,12 @@ def customHTMLMailMessage(attrs):
text = list()
text.append("<h3>STATUS <a href='%s'>%s</a>:</h3>" % (attrs['buildURL'],
attrs['result'].title()))
text.append("<h4>Recent Changes:</h4>")
for c in attrs['changes']:
text.append(template.module.change(**c.html_dict()))
# TODO: include the same filters in an email rendering as are available in
# web renderings (bug #691)

#text.append("<h4>Recent Changes:</h4>")
#for c in attrs['changes']:
# text.append(template.module.change(**c.html_dict()))

name, url, lines, status = attrs['logs'][-1]
text.append("<h4>Last %d lines of '%s':</h4>" % (logLines, name))
Expand Down Expand Up @@ -390,7 +393,7 @@ def testCustomHTMLMessage(self):
#
#self.fail(t)
self.failUnlessIn("<h4>Last 3 lines of 'step.test':</h4>", t)
self.failUnlessIn("Changed by: <b>author2</b>", t)
#self.failUnlessIn("Changed by: <b>author2</b>", t) # see comments in customHTMLMailMessage, above
self.failUnlessIn("Test 3 failed", t)
self.failUnlessIn("number was: 1", t)

Expand Down

0 comments on commit a119a02

Please sign in to comment.