Skip to content

Commit

Permalink
Point to refs buildbot#658
Browse files Browse the repository at this point in the history
  • Loading branch information
krajaratnam committed Feb 12, 2010
1 parent 2ef1a71 commit b132c59
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions buildbot/status/web/base.py
Expand Up @@ -384,7 +384,7 @@ def createJinjaEnv(revlink=None, changecommentlink=None):
''' Create a jinja environment changecommentlink is used to
render HTML in the WebStatus and for mail changes
@type changecommentlink: tuple (2 strings) or C{None}
@type changecommentlink: tuple (2 strings) or C{None}
@param changecommentlink: a regular expression and replacement string that is applied
to all change comments. The first element represents what to search
for and the second yields an url (the <a href=""></a> is added outside this)
Expand All @@ -398,17 +398,17 @@ def createJinjaEnv(revlink=None, changecommentlink=None):
(The revision id will be URL encoded before inserted in the replacement string)
'''

if hasattr(sys, "frozen"):
assert False, 'Frozen config not supported with jinja (yet)'
# See http://buildbot.net/trac/ticket/658
assert not hasattr(sys, "frozen"), 'Frozen config not supported with jinja (yet)'

default_loader = jinja2.PackageLoader('buildbot.status.web', 'templates')
root = os.path.join(os.getcwd(), 'templates')
loader = jinja2.ChoiceLoader([jinja2.FileSystemLoader(root),
default_loader])
env = jinja2.Environment(loader=loader,
extensions=['jinja2.ext.i18n'],
trim_blocks=True,
undefined=AlmostStrictUndefined)
extensions=['jinja2.ext.i18n'],
trim_blocks=True,
undefined=AlmostStrictUndefined)

env.filters['urlencode'] = urllib.quote
env.filters['email'] = emailfilter
Expand Down

1 comment on commit b132c59

@marcus-sonestedt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't just ref to a ticket number in the commit message. Say what the commit's purpose/change is about, then ref the number.

  1. If we lose Trac or change system, the number is worthless
  2. It's cumbersome to have to look up the ticket to see what the change was about, especially on github which doesn't auto-link to BB's Trac.

Nice work otherwise, with all patches/commits lately. :)

Please sign in to comment.