forked from buildbot/buildbot
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Chris AtLee
committed
Mar 5, 2010
1 parent
95d0542
commit d04983d
Showing
1 changed file
with
1 addition
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d04983d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of setting everything on one line, you can use the - markers.
{% endfor -%} is missing one here. Replace with {%- endfor -%} to collapse all whitespace between and {% ..
d04983d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's what the -'s do!
So catlee's changes in the newlines in this diff aren't necessary -- just the "-"?
d04983d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Precisely.
(Sidenote: I don't know why catlee wanted the newlines removed in this case. I prefer at least one new-line per list item in general, to make the html more easier to read, but I assume there was a good reason here...)
d04983d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He's probably using some inferior browser like IE that gets confused by the whitespace ;)
d04983d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in http://github.com/djmitche/buildbot/commit/f29c62cdcadab5601108024b2a6c7235e6aa7180 - please let me know if this is wrong!
d04983d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ow.. dude.. you do not joke about such things.. ;-P
Commit looks good!