Minor console fixes (index error in code with sort-by-time + show cat…

…egory names in html properly)
djmitche · Jan 3, 2010 · da79b7d · da79b7d
1 parent 54aaca1
commit da79b7d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/buildbot/status/web/console.py b/buildbot/status/web/console.py
@@ -301,8 +301,10 @@ def getBuildsForRevision(self, request, builder, builderName, lastRevision,
                 builds.append(devBuild)
 
                 # Now break if we have enough builds.
-                if self.comparator.isRevisionEarlier(
-                    devBuild, builder.getBuild(-1).getChanges()[-1]):
+                c = builder.getBuild(-1).getChanges()
+                #XXX: c is sometimes an empty tuple, so c[-1] fails?!?!
+                if c and self.comparator.isRevisionEarlier(
+                    devBuild, c[-1]):
                     break
 
             build = build.getPreviousBuild()

diff --git a/buildbot/status/web/templates/console.html b/buildbot/status/web/templates/console.html
@@ -82,9 +82,8 @@ <h1>Console View</h1>
   <table width=95% class="Grid" border="0" cellspacing="0">
     <tr>
       <td width="33%" align="left" class="left_align">
-        <a href="{{ project_url }}">{{ project_name }}</a>
 {% if categories|length > 1 %}
-        <br><b>Categories:</b> {{ categories }}
+        <br><b>Categories:</b> {% for c in categories %}{{ c.name }} {% endfor %}
 {% endif %}
 {% if branch != ANYBRANCH %}
         <br><b>Branch:</b> {{ branch }}