Skip to content

Commit

Permalink
Merge commit 'c462bf85fc86c1710c23026231f56deb90b317f3' into jinja
Browse files Browse the repository at this point in the history
  • Loading branch information
marcus-sonestedt committed Dec 13, 2009
2 parents 2c803c3 + c462bf8 commit e06139f
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 2 deletions.
7 changes: 7 additions & 0 deletions buildbot/interfaces.py
Expand Up @@ -882,6 +882,13 @@ def requestSubmitted(request):
@type request: implementor of L{IBuildRequestStatus}
"""

def requestCancelled(builder, request):
"""A BuildRequest has been cancelled on the given Builder.
@type builder: L{buildbot.status.builder.BuilderStatus}
@type request: implementor of L{IBuildRequestStatus}
"""

def builderAdded(builderName, builder):
"""
A new Builder has just been added. This method may return an
Expand Down
2 changes: 1 addition & 1 deletion buildbot/process/builder.py
Expand Up @@ -456,7 +456,7 @@ def submitBuildRequest(self, req):
def cancelBuildRequest(self, req):
if req in self.buildable:
self.buildable.remove(req)
self.builder_status.removeBuildRequest(req.status)
self.builder_status.removeBuildRequest(req.status, cancelled=True)
return True
return False

Expand Down
3 changes: 3 additions & 0 deletions buildbot/status/base.py
Expand Up @@ -11,6 +11,9 @@ class StatusReceiver:
def requestSubmitted(self, request):
pass

def requestCancelled(self, builder, request):
pass

def buildsetSubmitted(self, buildset):
pass

Expand Down
5 changes: 4 additions & 1 deletion buildbot/status/builder.py
Expand Up @@ -1800,8 +1800,11 @@ def addBuildRequest(self, brstatus):
for w in self.watchers:
w.requestSubmitted(brstatus)

def removeBuildRequest(self, brstatus):
def removeBuildRequest(self, brstatus, cancelled=False):
self.pendingBuilds.remove(brstatus)
if cancelled:
for w in self.watchers:
w.requestCancelled(self, brstatus)

# buildStarted is called by our child BuildStatus instances
def buildStarted(self, s):
Expand Down

0 comments on commit e06139f

Please sign in to comment.