forked from buildbot/buildbot
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
don't use http logs on Twisted-2.5.0
Just fall back to the usual logging mechanism. Verified on a F7 system. Fixes buildbot#780.
- Loading branch information
Dustin J. Mitchell
committed
Apr 9, 2010
1 parent
45cc731
commit e0947b8
Showing
1 changed file
with
5 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0947b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably move the log message from the except block as well, so it also triggers if hasattr() returns false.
e0947b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, thanks for fixing the 2.5.0 fallback. I thought I did that with the try..except clause, which I stole from my buildbot.tac, but obviously it wasn't correct.
e0947b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point re: log message. And no problem with fixing it .. finding a 2.5.0 installation isn't easy!