Skip to content

Commit

Permalink
Merge branch 'subunitFixes'
Browse files Browse the repository at this point in the history
* subunitFixes:
  don't show "tests", favor self.name over hard coded "tests" (a build may actually have several test step)
  show name as the first line after a subunit test run
  don't print subunit.RemotedTestCase in problems, just the remotetestcase's id is sufficient
  • Loading branch information
Dustin J. Mitchell committed Jun 24, 2010
2 parents 6e717ac + 20c6ec5 commit e38eff3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions master/buildbot/steps/subunit.py
Expand Up @@ -23,7 +23,7 @@ def commandComplete(self, cmd):

count = failures + errors

text = []
text = [self.name]
text2 = ""

if not count:
Expand All @@ -37,7 +37,7 @@ def commandComplete(self, cmd):
text += ["no tests", "run"]
else:
results = FAILURE
text.append("tests")
#text.append("tests")
if failures:
text.append("%d %s" % \
(failures,
Expand Down Expand Up @@ -66,7 +66,7 @@ def createSummary(self, loog):
ob = self.ioObverser
problems = ""
for test, err in ob.errors + ob.failures:
problems += "%s\n%s" % (test, err)
problems += "%s\n%s" % (test.id(), err)
if problems:
self.addCompleteLog("problems", problems)
warnings = ob.warningio.getvalue()
Expand All @@ -76,4 +76,4 @@ def createSummary(self, loog):
def getText(self, cmd, results):
return self.text
def getText2(self, cmd, results):
return self.text2
return self.text2

0 comments on commit e38eff3

Please sign in to comment.