New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo and gerrit support to buildbot #8
Conversation
I could really use this. Need to figure out how to get my builders pulling from multiple git repos (both gerrit and a local mirror from github). The changesource looks a lot more awesome than what I was thinking about building. |
dustin, have you tried the patch? tardyp, from a brief review, this looks fine, but it needs documentation and the slave side needs tests. Will you be able to stick around and act as the maintainer for Repo support in Buildbot? Or perhaps there are a few people that can work together to maintain it (maybe dustin, too)? I'm hesitant to merge things I'm not familiar with if I don't know there's someone I can contact with any problems. |
I don't use repo, but I use gerrit. I don't have builds coming out of gerrit right now, but this is motivation to try it. It's going to be a couple of weeks before I can get anything done there, though. |
@tardyp - Would love to see this implemented for CyanogenMod. We are currently using buildbot with some very hacky ShellCommands to get repo sync going. Send me a PM on freenode (ChrisSoyars) and I'll invite you to our dev channel if you need some help. |
tardyp, this looks like a much-anticipated change, and there are other folks who are willing to help maintain it. Do you think you'll be able to add docs and tets? |
@DJMitch I wont be able to access my git client until next week. After that I will be pleased to collaborate with cyanogen guys and polish a little bit more the branch. |
Sounds great - thanks for the note! |
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
this implementation can download changes that are not yet merged this via 2 mechanisms: - parsing of gerritchangesource properties - custom properties send by user's forcebuild via web ui Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
This is done by using the gerrit stream-event feature of gerrit. for now, it only reports change-merged and patchset-created events Signed-off-by: Pierre Tardy <tardyp@gmail.com>
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
this forbids user to use the repo download fonctionality.. Signed-off-by: Pierre Tardy <tardyp@gmail.com>
Those patches implement first level of support of repo and gerrit to buildbot.
repo source fetcher fetches very big repo (android needs 2GB to download), using bootstrap tarball if available.
gerritchangesource connects to the gerrit ssh server to get changes information as it comes.
This is my first patch to buildbot, so it might be some comments, and some misuse of the framework.