merge stable #8988
Merged
merge stable #8988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ibuclaw
commented
Apr 25, 2024
ibuclaw
commented
- Remove dscanner check for const/immutable variables in unit tests.
- Work around bugzilla issue 24415 - only doesn't work with elements with a copy constructor.
This appears to be the check which is making dlang#8924 fail the style check with warnings such as std/internal/test/range.d(43:14)[warn]: Variable b is never modified and could have been declared const or immutable. It makes no sense to require that unit tests follow such a rule, and it is actually detrimental when tests involve stuff like copy constructors, because then the type of the target variable matters as part of the test. Honestly, I think that it should probably not be checked at all, since it's a pretty questionable requirement in many cases given how strict D's const and immutable are, but that's more debatable, whereas this check really makes no sense with unit tests, so I'm just disabling it for unit tests for now. We can disable it more generally later if it turns out that it's causing problems for normal code.
…th a copy constructor. Since the compiler is treating the auto-generated copy-constructor for OnlyResult as private (thus rendering it useless outside of std.range.package), this commit adds an explicit one and makes it public. Once the dmd bug has been fixed, the explicit copy constructor should be removed.
ibuclaw
requested review from
andralex,
JackStouffer,
wilzbach and
PetarKirov
as code owners
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8988" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.