possibility to create custom discriminator types

dmgr · Mar 29, 2010 · 58017d0 · snusnu · Mar 29, 2010 · 58017d0
1 parent f07e775
commit 58017d0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/lib/dm-core/model.rb b/lib/dm-core/model.rb
@@ -548,7 +548,7 @@ def load(records, query)
             record = record.dup
             field_map.each { |property, field| record[property] = record.delete(field) if record.key?(field) }
 
-            model     = discriminator && record[discriminator] || self
+            model     = discriminator && (klass = record[discriminator]) && discriminator.typecast(klass) || self
             model_key = model.key(repository_name)
 
             resource = if model_key.valid?(key_values = record.values_at(*model_key))

diff --git a/lib/dm-core/property_set.rb b/lib/dm-core/property_set.rb
@@ -68,7 +68,7 @@ def key
 
     # @api semipublic
     def discriminator
-      @discriminator ||= detect { |property| property.type == Types::Discriminator }
+      @discriminator ||= detect { |property| property.type.ancestors.include?(Types::Discriminator) }
     end
 
     # @api semipublic

diff --git a/spec/public/types/discriminator_spec.rb b/spec/public/types/discriminator_spec.rb
@@ -3,12 +3,18 @@
 describe DataMapper::Types::Discriminator do
   before :all do
     module ::Blog
+      class NewDiscriminator < DataMapper::Types::Discriminator
+        primitive Class
+        default   lambda { |resource, property| resource.model }
+        required  true
+      end
+
       class Article
         include DataMapper::Resource
 
         property :id,    Serial
         property :title, String, :required => true
-        property :type,  Discriminator
+        property :type,  NewDiscriminator
       end
 
       class Announcement < Article; end