Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D Impact Parameters plots and Barycenter plots for Alignment Workspace in Offline DQM GUI #1063

Merged

Conversation

dmeuser
Copy link
Contributor

@dmeuser dmeuser commented Jul 8, 2021

This PR intends to add the new 2D impact parameter plots(cms-sw/cmssw#33693) and barycenter plots(cms-sw/cmssw#34312) to the alignment workspace of the offline DQM GUI.
In detail the PR includes the following:

  • Adding style options for the 2D impact parameters plots in dqmgui/layouts/aliOfflinePV_T0_layouts.py
  • Adding the 2D impact parameters plots to the offlinePV alignment layout in dqmgui/style/OfflinePVAlignmentRenderPlugin.cc
  • Adding the barycenter plots to the pixelPhase1 layout in dqmgui/layouts/pixelPhase1_T0_layouts.py
  • Adding both type of plots to the alignment workspace in dqmgui/workspaces-offline.py

The PR was tested with the HG2107d tag and a private data sample on a private DQM GUI. For now the private GUI can be found by using ssh -NL 8080:localhost:8080 @lxplus710.cern.ch and then following this link https://tinyurl.com/yggr5b98.

@mmusich, @arossi83, @sroychow

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 8, 2021

Hi @muhammadimranfarooqi,
I believe this PR can be integrated at your earliest convenience
Thanks!

@muhammadimranfarooqi muhammadimranfarooqi merged commit 49ef4c7 into dmwm:master Jul 12, 2021
@muhammadimranfarooqi
Copy link
Contributor

@dmeuser @jfernan2

This PR has been deployed in testbed. Please provide validation at https://gitlab.cern.ch/cms-http-group/doc/-/issues/270
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants