Support GenericResources in ServiceSpec.TaskTemplate.Resources.Reservations #2327
Conversation
| public T getValue() { | ||
| return value; | ||
| } | ||
| public abstract T getValue(); |
There was a problem hiding this comment.
Note to any potential reviewers: This is causing the build to fail because it is an API change; the method used to be concrete but is now abstract. But IMO it's a valid change. It isn't going to impact any users because no one was constructing these GenericResources before anyway. There was no way to do so.
I suppose I could leave it non-abstract, keep a T value property here, and make the child classes basically empty shells with declarations only. But it really doesn't make any sense for users to be able to construct GenericResource instances, this should be abstract, if you tried to pass one to the docker API it would fail.
All of that to say, I don't know how to bypass the API change check so that the build can succeed.
Closes #2320