DOCKER_TLS_VERIFY can be 'false' or empty.

[hongweiyi]

closes #519
Signed-off-by: hongwei yi hongweiyi@hotmail.com

---

This change is

[KostyaSha]

Looks not very good for eyes, have you looked at org.apache.commons.lang.BooleanUtils#toBooleanObject(java.lang.String) ?

[hongweiyi]

Maybe org.apache.commons.lang.BooleanUtils#toBooleanObject(java.lang.String) is too complicated in this case, "true".equals(trimmed) || "1".equals(trimmed) is simple, fast and straight forward.

[KostyaSha]

Well, all Utils are available to simplify the code readability and i think one of them should work. Can't get idea what is wrong 🏧 and why utils can't be used... toBoolean() calls toBooleanObject()

[KostyaSha]

and imho TRUE should also work as true, so better to use existed utils, they are already verified and covers different corner cases.

[hongweiyi]

LOL, there always two ways. 1. make maximum use of Utils; 2. make code as simple as possible.

But I'm the latter one, I perfect has third libraries as little as possible.

As the former one, if BooleanUtils has a method to pass default value, it will looks very good for eyes, just like:

toBoolean(str, trueStr, falseStr, defaultValue);

Or if docker-java does not want user to set invalid value to DOCKER_TLS_VERIFY, it should throw exception directly.

[codecov-io]

Current coverage is 22.82%

Merging #520 into master will increase coverage by +0.03% as of 6375c7d

@@            master    #520   diff @@
======================================
  Files          294     294       
  Stmts         6077    6078     +1
  Branches       526     526       
  Methods          0       0       
======================================
+ Hit           1385    1387     +2
+ Partial         83      82     -1
  Missed        4609    4609       

Review entire Coverage Diff as of 6375c7d

Powered by Codecov. Updated on successful CI builds.

[hongweiyi]

Some problems with 3rd party libraries in nodejs : ) .

http://www.haneycodes.net/npm-left-pad-have-we-forgotten-how-to-program/