Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup improper regex usage #315

Merged
merged 3 commits into from Feb 3, 2020
Merged

Conversation

devpaul
Copy link
Member

@devpaul devpaul commented Jan 23, 2020

This resolves a potential xss when using the dojox.xmpp.util.xmlEncode method.

The output was used by RosterService to subscribe a valid xml encoded name. The name is never attached directly to the DOM, but is sent to the xmpp server as XML. It may affect xmpp servers without proper input handling or users that use dojox.smpp.util.xmlEncode() directly who add its output to a page.

@devpaul devpaul requested a review from dylans January 23, 2020 22:55
@devpaul devpaul changed the title potential xss in dojox.xmpp.util.xmlEncode Cleanup improper regex usage Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants