New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP8.1 fixes #3908
PHP8.1 fixes #3908
Conversation
…ithout first startSectionEdit
@splitbrain Hello, I've fixed the problems you've mentioned, and I've also found a bug (at least I presume it's a bug - I didn't get any warnings / errors after applying 170f205), where the whole image would get re-read after reading any tag. Please let me know if you'd like me to change anything else. |
Nice work. I changed the exception handling slightly in d40e7d0 Since you seem to be somewhat familiar with the JpegMeta code by now and have started fixing bugs, I see two options if you would want to dig deeper:
Just a suggestion in case you want to dig a little deeper. |
Thanks a lot! I might look into it, though not sure which way would be the best to go. The way I see it is, PEL would probably be better for Exif-only, but the current JpegMeta implementation supports not only Exif metadata, but also Adobe and some others, so by going with PEL we'd lose some functionality in favor of more stable code. I'll think about it, and might do a PR with one of the solutions you've listed above later. |
Fixed #3900 and #3890 among other warnings.