Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8.1 fixes #3908

Merged
merged 9 commits into from Mar 11, 2023
Merged

PHP8.1 fixes #3908

merged 9 commits into from Mar 11, 2023

Conversation

asivery
Copy link
Contributor

@asivery asivery commented Mar 7, 2023

Fixed #3900 and #3890 among other warnings.

inc/File/PageResolver.php Outdated Show resolved Hide resolved
inc/JpegMeta.php Outdated Show resolved Hide resolved
inc/parser/xhtml.php Outdated Show resolved Hide resolved
@splitbrain splitbrain added this to ToDo in Jack Jackrum via automation Mar 8, 2023
@asivery
Copy link
Contributor Author

asivery commented Mar 9, 2023

@splitbrain Hello, I've fixed the problems you've mentioned, and I've also found a bug (at least I presume it's a bug - I didn't get any warnings / errors after applying 170f205), where the whole image would get re-read after reading any tag. Please let me know if you'd like me to change anything else.

inc/template.php Outdated Show resolved Hide resolved
inc/JpegMeta.php Show resolved Hide resolved
inc/File/PageResolver.php Outdated Show resolved Hide resolved
@splitbrain splitbrain merged commit a46a7ce into dokuwiki:master Mar 11, 2023
Jack Jackrum automation moved this from ToDo to Done Mar 11, 2023
@splitbrain
Copy link
Collaborator

splitbrain commented Mar 11, 2023

Nice work. I changed the exception handling slightly in d40e7d0

Since you seem to be somewhat familiar with the JpegMeta code by now and have started fixing bugs, I see two options if you would want to dig deeper:

  1. if you're interested in maintaining your own Open Source project, extracting the the JpegMeta class into its own composer project might be interesting. It would need a lot of clean up, adding unit tests and maybe refactoring it into multiple classes.
  2. we are thinking of replacing this class completely, by a better maintained project (see Make 3rd party libs composer dependencies #1970). https://github.com/pel/pel seems to be the most likely candidate. a DokuWiki PR replacing the use of JpegMeta with a composer dependency like PEL would be very welcome.

Just a suggestion in case you want to dig a little deeper.

@asivery
Copy link
Contributor Author

asivery commented Mar 11, 2023

Thanks a lot! I might look into it, though not sure which way would be the best to go. The way I see it is, PEL would probably be better for Exif-only, but the current JpegMeta implementation supports not only Exif metadata, but also Adobe and some others, so by going with PEL we'd lose some functionality in favor of more stable code. I'll think about it, and might do a PR with one of the solutions you've listed above later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Incorrect GPS values parsing from EXIF in JPGs
2 participants