New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #136 - Bugfix test_dnssec method cache #137

Open

mohammad-latacora wants to merge 1 commit into domainaware:master from mohammad-latacora:issue-136/dnssec-cache-bugfix

mohammad-latacora commented May 16, 2024

checkdmarc/checkdmarc/dnssec.py

Line 109 in 3d3da6e

return DNSSEC_CACHE[cache]

This line is attempting to access a cache within a cache. This throws an unhashable type: 'ExpiringDict' error.

This PR proposes replacing that with the following

  if domain in cache:
      return cache[domain]

Which is identical to what is used by the get_dnskey method on line 57


          Bugfix test_dnssec cache

3e5a414

mohammad-latacora mentioned this pull request

test_dnssec method incorrectly accessing the cache #136

Open

Contributor

aharpour commented May 17, 2024

I ran into the same issue and it fixed it for me. @mohammad-latacora Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment