Updated to make Rendering and FileSystem operations async by default. #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having async as an option, great. Forcing everything to async as a breaking change... maybe not great. |
|
I entirely agree! |
|
As this seems to have forked to another library and no feedback on how we can make this backwards compatible, can we close this PR? |
This is held up because there is no contributor addressing the acknowledge issues with the draft PR. The draft was done in a major breaking way. If a contributor wanted to step up, the change to asynchronous would need to be introduced as a set of parallel async public APIs, so the existing sync public APIs are not altered, and no existing client is broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR that is not really intended to be merged, but I am creating it for discussion. (Hence it is created as a draft.)
It is a significant breaking change that changes the file system and rendering operations to be async-by-default.
I would like to create some side-by-side benchmarking to understand the perf impact of these changes in various scenarios.