Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix condition check null string throw null pointer exception #513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hieuvuvan
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 88.26% // Head: 88.26% // No change to project coverage 👍

Coverage data is based on head (ff11ecb) compared to base (aaa5026).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   88.26%   88.26%           
=======================================
  Files          69       69           
  Lines        2676     2676           
  Branches      620      620           
=======================================
  Hits         2362     2362           
  Misses        210      210           
  Partials      104      104           
Impacted Files Coverage Δ
src/DotLiquid/Condition.cs 98.48% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@microalps
Copy link
Contributor

@hieuvuvan couple of details needed here:

  1. What's the expected outcome in the reverse - if null is the left and string is the right?
  2. Can you post an example on replit that reproduces the same scenarios on ruby liquid and shows we have a difference in implementation?

@hieuvuvan
Copy link
Contributor Author

hieuvuvan commented Dec 14, 2022

@microalps

  1. i think existing test covered this case - the outcome is false
  2. well, i see in ruby implementation, the outcome is false but we throw null pointer exception for that case

@hieuvuvan hieuvuvan changed the title fix condition check null string fix condition check null string throw null pointer exception Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants