Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Check for OS build number version Runtime #853

Merged

Conversation

AskBojesen
Copy link
Contributor

@AskBojesen AskBojesen commented May 16, 2024

To fix #852

I have also added an installer project to easily test on another computer.
Eg. I have tested the winconsole on a Windows 10 with build number = 19041

@AskBojesen AskBojesen changed the title Windows: Check for SDK version Runtime Windows: Check for OS build number version Runtime May 16, 2024
@janusw
Copy link
Member

janusw commented May 16, 2024

@CodeMusher You reported in #849 that there are InvalidCastException when targeting Windows builds > 22k, but running on builds < 22k. Can you confirm that this PR fixes those exceptions?

@CodeMusher
Copy link

CodeMusher commented May 17, 2024 via email

Copy link
Member

@janusw janusw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, yeah, this is ok with me (with the latest changes and the confirmation that it fixes the issue).

@janusw janusw merged commit 8cc17fc into dotnet-bluetooth-le:master May 18, 2024
3 checks passed
@janusw
Copy link
Member

janusw commented May 19, 2024

I'd tend toward releasing 3.1.0 now (today or tomorrow). I think the most urgent things are fixed and further bugfixes can still be added in subsequent 3.1.x releases.

@AskBojesen Is this ok with you, or do you want anything else to be included in 3.1.0? Do we need another rc?

@AskBojesen
Copy link
Contributor Author

I'd tend toward releasing 3.1.0 now (today or tomorrow). I think the most urgent things are fixed and further bugfixes can still be added in subsequent 3.1.x releases.

@AskBojesen Is this ok with you, or do you want anything else to be included in 3.1.0? Do we need another rc?

No thanks! I tried to reproduce disconnect hangs sometimes on Windows. But could not - did 200 connect/disconnect on two different devices.

Looking forward to the 3.1.0 release :-)

@AskBojesen AskBojesen deleted the Windows_Check_OS_version_runtime branch May 19, 2024 09:23
@CodeMusher
Copy link

CodeMusher commented May 19, 2024 via email

@janusw
Copy link
Member

janusw commented May 19, 2024

Hi, would it be possible to get a fix for my issue regarding INDICATE characteristic on Windows into the release?

Well, I'm not sure. You mean #847, right? I haven't looked looked at that issue, but if it's easily fixed and either you or @AskBojesen can post a PR in the next days, we can still defer the release a bit. I would like to publish it within a week, though.

(Note that I am not a Windows native, so I'm not much help in testing or fixing Windows-related issues.)

@CodeMusher
Copy link

Yes, #847 is the one. I’ve written a solution in the issue that works for my use case. @AskBojesen do you think that is acceptable or could a characteristic have both INDICATE and NOTIFY?

@janusw
Copy link
Member

janusw commented May 19, 2024

@AskBojesen do you think that is acceptable or could a characteristic have both INDICATE and NOTIFY?

Please continue this discussion in #847 (or the PR you'll open to fix it). It is highly off-topic here ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: Check OS version runtime
3 participants