-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Check for OS build number version Runtime #853
Windows: Check for OS build number version Runtime #853
Conversation
@CodeMusher You reported in #849 that there are |
Yes, it does!16 maj 2024 kl. 21:31 skrev Janus Weil ***@***.***>:
@CodeMusher You reported in #849 that there are InvalidCastException when targeting Windows builds > 22k, but running on builds < 22k. Can you confirm that this PR fixes those exceptions?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, yeah, this is ok with me (with the latest changes and the confirmation that it fixes the issue).
I'd tend toward releasing 3.1.0 now (today or tomorrow). I think the most urgent things are fixed and further bugfixes can still be added in subsequent 3.1.x releases. @AskBojesen Is this ok with you, or do you want anything else to be included in 3.1.0? Do we need another rc? |
No thanks! I tried to reproduce disconnect hangs sometimes on Windows. But could not - did 200 connect/disconnect on two different devices. Looking forward to the 3.1.0 release :-) |
Hi, would it be possible to get a fix for my issue regarding INDICATE characteristic on Windows into the release?Skickat från min iPhone19 maj 2024 kl. 11:23 skrev Ask Magnussen Bojesen ***@***.***>:
I'd tend toward releasing 3.1.0 now (today or tomorrow). I think the most urgent things are fixed and further bugfixes can still be added in subsequent 3.1.x releases.
@AskBojesen Is this ok with you, or do you want anything else to be included in 3.1.0? Do we need another rc?
No thanks! I tried to reproduce disconnect hangs sometimes on Windows. But could not - did 200 connect/disconnect on two different devices.
Looking forward to the 3.1.0 release :-)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Well, I'm not sure. You mean #847, right? I haven't looked looked at that issue, but if it's easily fixed and either you or @AskBojesen can post a PR in the next days, we can still defer the release a bit. I would like to publish it within a week, though. (Note that I am not a Windows native, so I'm not much help in testing or fixing Windows-related issues.) |
Yes, #847 is the one. I’ve written a solution in the issue that works for my use case. @AskBojesen do you think that is acceptable or could a characteristic have both INDICATE and NOTIFY? |
Please continue this discussion in #847 (or the PR you'll open to fix it). It is highly off-topic here ;) |
To fix #852
I have also added an installer project to easily test on another computer.
Eg. I have tested the winconsole on a Windows 10 with build number = 19041