Refactor shared framework projects targets and project layout #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 22, 2018 17:07
This moves the targets used to build the shared framework into a project file. It also makes a few other improvements * No need to generate an intermediate package to run restore * Lays the foundation for future refactorings of hte framework, such as flattening the package graph * Remove shared framework targets from the KoreBuild context
* Change the output of shared framework projects to keep files in distinct groups * Generate rid-specific packages for shared frameworks
added 3 commits
October 23, 2018 14:54
* Tie together metapackage and shared framework generation * Add tests to ensure deps.json for the shared framework only has "package" entries * Remove Microsoft.AspNetCore.Analyzers (this package isn't shipping anyways) * Cleanup artifacts.props to only include the shipping category
|
D:\a\1\s\build\repo.targets(28,34): error MSB4057: The target "GetMetapackageArtifactInfo" does not exist in the project. [D:\a.dotnet\buildtools\korebuild\2.2.0-preview2-20181019.5\KoreBuild.proj] |
|
🆙 📅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the targets used to build the shared framework and its .zip files. There are lots of reasons motivating this: Arcade convergence, migration to VSTS, making it easier to build this locally, etc.
Changes:
runtime.$rid.Microsoft.AspNetCore.Apppackage (not just the one with symbols in it) - Produce platform-specific packages for Microsoft.AspNetCore.App #3607src/Installers/dotnet build -p src/Framework/Microsoft.AspNetCore.App/src/ -r win-x64)This also lays the foundation for some important next steps:
cref https://github.com/aspnet/AspNetCore-Internal/issues/759, #3653, https://github.com/aspnet/BuildTools/issues/727, dotnet/arcade#88