[HTTP/3] Support for HTTP/3 multiple connections #101531

ManickaP · 2024-04-25T08:29:49Z

Feel free to review and discuss the API changes. This is NO MERGE until we have the APIs approved and all the TODOs resolved

The implementation takes H/2 connection pooling and slightly adjusts it for H/3 specific behaviors (see a diff between HttpConnectionPool.Http2.cs and HttpConnectionPool.Http3.cs).

The PR depends on 2 API reviews:

[API Proposal]: [HTTP/3] Support multiple HTTP/3 connections #101535: for EnableMultipleHttp3Connections
[API Proposal]: [QUIC] Support managing available streams on QuicConnection #101534: for QuicConnection changes

TODO: Add numbers from benchmarks when it runs
TODO: Stress run depends on dotnet/aspnetcore#55282

Fixes #51775
Fixes #54968
Fixes #68380
Resolves #101535
Resolves #101534

dotnet-issue-labeler · 2024-04-25T08:29:54Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ManickaP · 2024-04-25T10:43:04Z

No noticeable regression on perf from main:

main

1x10000 (clients x threads)

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/httpclient.benchmarks.yml --client.framework net9.0 --server.framework net9.0 --scenario httpclient-kestrel-get --profile intel-lin-app --profile amd-lin2-load --variable useHttpMessageInvoker=true --variable httpVersion=3.0 --variable useHttps=true --variable responseSize=256 --variable numberOfHttpClients=1 --variable concurrencyPerHttpClient=10000

| client                      |                                       |
| --------------------------- | ------------------------------------- |
| Max CPU Usage (%)           | 35                                    |
| Max Cores usage (%)         | 971                                   |
| Max Working Set (MB)        | 3,810                                 |
| Max Private Memory (MB)     | 4,415                                 |
| Build Time (ms)             | 6,988                                 |
| Start Time (ms)             | 0                                     |
| Published Size (KB)         | 74,115                                |
| Symbols Size (KB)           | 19                                    |
| .NET Core SDK Version       | 9.0.100-preview.5.24224.9             |
| ASP.NET Core Version        | 9.0.0-preview.4.24223.1+f18510c2fbdf  |
| .NET Runtime Version        | 9.0.0-preview.4.24223.11+d92ac1f892a7 |
| Processor Count             | 28                                    |
| First request duration (ms) | 519                                   |
| Requests                    | 345,446                               |
| Bad Status Code Requests    | 0                                     |
| Exceptions                  | 0                                     |
| Mean RPS                    | 23,069                                |

1x100 (clients x threads)

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/httpclient.benchmarks.yml --client.framework net9.0 --server.framework net9.0 --scenario httpclient-kestrel-get --profile intel-lin-app --profile amd-lin2-load --variable useHttpMessageInvoker=true --variable httpVersion=3.0 --variable useHttps=true --variable responseSize=256 --variable numberOfHttpClients=1 --variable concurrencyPerHttpClient=100

| client                      |                                       |
| --------------------------- | ------------------------------------- |
| Max CPU Usage (%)           | 41                                    |
| Max Cores usage (%)         | 1,150                                 |
| Max Working Set (MB)        | 577                                   |
| Max Private Memory (MB)     | 1,119                                 |
| Build Time (ms)             | 4,926                                 |
| Start Time (ms)             | 0                                     |
| Published Size (KB)         | 74,115                                |
| Symbols Size (KB)           | 19                                    |
| .NET Core SDK Version       | 9.0.100-preview.5.24225.1             |
| ASP.NET Core Version        | 9.0.0-preview.4.24223.1+f18510c2fbdf  |
| .NET Runtime Version        | 9.0.0-preview.4.24223.11+d92ac1f892a7 |
| Processor Count             | 28                                    |
| First request duration (ms) | 520                                   |
| Requests                    | 989,468                               |
| Bad Status Code Requests    | 0                                     |
| Exceptions                  | 0                                     |
| Mean RPS                    | 65,955                                |

20x500 (clients x threads)

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/httpclient.benchmarks.yml --client.framework net9.0 --server.framework net9.0 --scenario httpclient-kestrel-get --profile intel-lin-app --profile amd-lin2-load --variable useHttpMessageInvoker=true --variable httpVersion=3.0 --variable useHttps=true --variable responseSize=256 --variable numberOfHttpClients=20 --variable concurrencyPerHttpClient=500

| client                      |                                       |
| --------------------------- | ------------------------------------- |
| Max CPU Usage (%)           | 97                                    |
| Max Cores usage (%)         | 2,710                                 |
| Max Working Set (MB)        | 6,526                                 |
| Max Private Memory (MB)     | 7,268                                 |
| Build Time (ms)             | 2,544                                 |
| Start Time (ms)             | 0                                     |
| Published Size (KB)         | 74,115                                |
| Symbols Size (KB)           | 19                                    |
| .NET Core SDK Version       | 9.0.100-preview.5.24225.1             |
| ASP.NET Core Version        | 9.0.0-preview.4.24223.1+f18510c2fbdf  |
| .NET Runtime Version        | 9.0.0-preview.4.24223.11+d92ac1f892a7 |
| Processor Count             | 28                                    |
| First request duration (ms) | 518                                   |
| Requests                    | 4,976,883                             |
| Bad Status Code Requests    | 0                                     |
| Exceptions                  | 0                                     |
| Mean RPS                    | 331,779                               |

PR, multiple H3 connections OFF

1x10000 (clients x threads)

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/httpclient.benchmarks.yml --client.framework net9.0 --server.framework net9.0 --scenario httpclient-kestrel-get --profile intel-lin-app --profile amd-lin2-load --variable useHttpMessageInvoker=true --variable httpVersion=3.0 --variable useHttps=true --variable responseSize=256 --variable numberOfHttpClients=1 --variable concurrencyPerHttpClient=10000 --client.options.outputFiles artifacts/bin/testhost/net9.0-linux-Release-x64/shared/Microsoft.NETCore.App/9.0.0/System.Net.Http.dll --client.options.outputFiles  artifacts/bin/testhost/net9.0-linux-Release-x64/shared/Microsoft.NETCore.App/9.0.0/System.Net.Quic.dll

| client                      |                                       |
| --------------------------- | ------------------------------------- |
| Max CPU Usage (%)           | 36                                    |
| Max Cores usage (%)         | 998                                   |
| Max Working Set (MB)        | 3,772                                 |
| Max Private Memory (MB)     | 4,371                                 |
| Build Time (ms)             | 2,866                                 |
| Start Time (ms)             | 0                                     |
| Published Size (KB)         | 74,115                                |
| Symbols Size (KB)           | 19                                    |
| .NET Core SDK Version       | 9.0.100-preview.5.24225.1             |
| ASP.NET Core Version        | 9.0.0-preview.4.24223.1+f18510c2fbdf  |
| .NET Runtime Version        | 9.0.0-preview.4.24223.11+d92ac1f892a7 |
| Processor Count             | 28                                    |
| First request duration (ms) | 596                                   |
| Requests                    | 342,841                               |
| Bad Status Code Requests    | 0                                     |
| Exceptions                  | 0                                     |
| Mean RPS                    | 22,914                                |

1x100 (clients x threads)

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/httpclient.benchmarks.yml --client.framework net9.0 --server.framework net9.0 --scenario httpclient-kestrel-get --profile intel-lin-app --profile amd-lin2-load --variable useHttpMessageInvoker=true --variable httpVersion=3.0 --variable useHttps=true --variable responseSize=256 --variable numberOfHttpClients=1 --variable concurrencyPerHttpClient=100 --client.options.outputFiles artifacts/bin/testhost/net9.0-linux-Release-x64/shared/Microsoft.NETCore.App/9.0.0/System.Net.Http.dll --client.options.outputFiles  artifacts/bin/testhost/net9.0-linux-Release-x64/shared/Microsoft.NETCore.App/9.0.0/System.Net.Quic.dl

| client                      |                                       |
| --------------------------- | ------------------------------------- |
| Max CPU Usage (%)           | 46                                    |
| Max Cores usage (%)         | 1,296                                 |
| Max Working Set (MB)        | 587                                   |
| Max Private Memory (MB)     | 1,174                                 |
| Build Time (ms)             | 2,897                                 |
| Start Time (ms)             | 0                                     |
| Published Size (KB)         | 74,115                                |
| Symbols Size (KB)           | 19                                    |
| .NET Core SDK Version       | 9.0.100-preview.5.24225.1             |
| ASP.NET Core Version        | 9.0.0-preview.4.24223.1+f18510c2fbdf  |
| .NET Runtime Version        | 9.0.0-preview.4.24223.11+d92ac1f892a7 |
| Processor Count             | 28                                    |
| First request duration (ms) | 594                                   |
| Requests                    | 985,119                               |
| Bad Status Code Requests    | 0                                     |
| Exceptions                  | 0                                     |
| Mean RPS                    | 65,691                                |

20x500 (clients x threads)

rank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/httpclient.benchmarks.yml --client.framework net9.0 --server.framework net9.0 --scenario httpclient-kestrel-get --profile intel-lin-app --profile amd-lin2-load --variable useHttpMessageInvoker=true --variable httpVersion=3.0 --variable useHttps=true --variable responseSize=256 --variable numberOfHttpClients=20 --variable concurrencyPerHttpClient=500 --client.options.outputFiles artifacts/bin/testhost/net9.0-linux-Release-x64/shared/Microsoft.NETCore.App/9.0.0/System.Net.Http.dll --client.options.outputFiles  artifacts/bin/testhost/net9.0-linux-Release-x64/shared/Microsoft.NETCore.App/9.0.0/System.Net.Quic.dll

| client                      |                                       |
| --------------------------- | ------------------------------------- |
| Max CPU Usage (%)           | 95                                    |
| Max Cores usage (%)         | 2,667                                 |
| Max Working Set (MB)        | 6,494                                 |
| Max Private Memory (MB)     | 7,246                                 |
| Build Time (ms)             | 2,660                                 |
| Start Time (ms)             | 0                                     |
| Published Size (KB)         | 74,115                                |
| Symbols Size (KB)           | 19                                    |
| .NET Core SDK Version       | 9.0.100-preview.5.24225.1             |
| ASP.NET Core Version        | 9.0.0-preview.4.24223.1+f18510c2fbdf  |
| .NET Runtime Version        | 9.0.0-preview.4.24223.11+d92ac1f892a7 |
| Processor Count             | 28                                    |
| First request duration (ms) | 594                                   |
| Requests                    | 5,334,724                             |
| Bad Status Code Requests    | 0                                     |
| Exceptions                  | 0                                     |
| Mean RPS                    | 355,707                               |

PR, multiple H3 connections ON

1x10000 (clients x threads)

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/httpclient.benchmarks.yml --client.framework net9.0 --server.framework net9.0 --scenario httpclient-kestrel-get --profile intel-lin-app --profile amd-lin2-load --variable useHttpMessageInvoker=true --variable httpVersion=3.0 --variable useHttps=true --variable responseSize=256 --variable numberOfHttpClients=1 --variable concurrencyPerHttpClient=10000 --client.options.outputFiles artifacts/bin/testhost/net9.0-linux-Release-x64/shared/Microsoft.NETCore.App/9.0.0/System.Net.Http.dll --client.options.outputFiles  artifacts/bin/testhost/net9.0-linux-Release-x64/shared/Microsoft.NETCore.App/9.0.0/System.Net.Quic.dll

| client                      |                                      |
| --------------------------- | ------------------------------------ |
| Max CPU Usage (%)           | 92                                   |
| Max Cores usage (%)         | 2,572                                |
| Max Working Set (MB)        | 6,491                                |
| Max Private Memory (MB)     | 7,228                                |
| Build Time (ms)             | 2,736                                |
| Start Time (ms)             | 0                                    |
| Published Size (KB)         | 74,777                               |
| Symbols Size (KB)           | 19                                   |
| .NET Core SDK Version       | 9.0.100-preview.5.24272.19           |
| ASP.NET Core Version        | 9.0.0-preview.6.24272.7+49c1c68bf1ac |
| .NET Runtime Version        | 9.0.0-preview.5.24272.2+5c06e5d01fa0 |
| Processor Count             | 28                                   |
| First request duration (ms) | 594                                  |
| Requests                    | 4,325,325                            |
| Bad Status Code Requests    | 0                                    |
| Exceptions                  | 0                                    |
| Mean RPS                    | 288,664                              |

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/SocketsHttpHandler.cs

src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/ConnectHelper.cs

.../System.Net.Http/src/System/Net/Http/SocketsHttpHandler/ConnectionPool/HttpConnectionPool.cs

MihaZupan · 2024-04-25T13:45:10Z

src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs

+    /// Occurres when an additional stream capacity has been released by the peer. Corresponds to receiving MAX_STREAMS frame.
+    /// </summary>
+    public event QuicConnectionStreamsAvailableEventHandler? StreamsAvailable;
+    private async void OnStreamsAvailable(int bidirectionalStreamsCountIncrement, int unidirectionalStreamsCountIncrement)


Suggested change

private async void OnStreamsAvailable(int bidirectionalStreamsCountIncrement, int unidirectionalStreamsCountIncrement)

private async Task OnStreamsAvailable(int bidirectionalStreamsCountIncrement, int unidirectionalStreamsCountIncrement)

Gag reflex whenever I see async void 😃
E.g. it could be a regular async Task with the caller doing _ = OnStreamsAvailable(), like we do for InjectNewHttp3ConnectionAsync.

It's probably fine in this case though.

I actually prefer async void to _ = BlaBlaAsync() 😄 And we have a precedent for it in S.N.Quic (which I authored 😃 )

src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs

...m.Net.Http/src/System/Net/Http/SocketsHttpHandler/ConnectionPool/HttpConnectionPool.Http3.cs

…andler/Http3Connection.cs Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com>

…properties

ManickaP · 2024-05-16T09:31:53Z

Change of the logic: StreamsAvailable has been made a regular callback and moved to QuicConnectionOptions (thanks @rzikm for the suggestion). This is more aligned with how we handle callbacks/events in SslStream. After all, events are not a common occurrence in our stack. It also solves an issue with the correctness of the provided values in regards to thread safety. There's no chance of registering to the event in the middle of opening stream or processing STREAMS_AVAILABLE event. The callback is registered before the connection is created and the callback is always invoked as a reaction to a MsQuic event. The only thing that could happen is that invocations of the callback might swap order since we must offload the callback execution from MsQuic thread to the thread-pool. However, we are providing increments, so it doesn't matter that much as a+b == b+a.

…st RFC

dotnet/runtime#101531 (comment)

...m.Net.Http/src/System/Net/Http/SocketsHttpHandler/ConnectionPool/HttpConnectionPool.Http3.cs

src/libraries/System.Net.Quic/ref/System.Net.Quic.cs

dotnet/runtime#101531 (comment)

MihaZupan

Left a few more comments but otherwise this LGTM.

It's good that it substantially mimics the H2 logic, makes it much easier to follow.

MihaZupan · 2024-05-23T17:26:30Z

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs

@@ -210,6 +284,7 @@ public async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, lon

                if (quicStream == null)
                {
+                    ReleaseStream();


Is this a 100% reliable way to detect whether the underlying QuicConnection counted the stream as consumed or not?
E.g. even when OpenOutboundStreamAsync is cancelled?

Good catch, this is not actually right, in both cases we should not re-increment the count (only if we didn't even try to open the stream). I did some testing and added some comments to QuicStream to make sure we have consistent behavior wrt stream counts regardless whether the call gets cancelled or not.

MihaZupan · 2024-05-23T17:36:24Z

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs

+                Debug.Assert(_availableRequestStreamsCount >= 0);
+
+                if (NetEventSource.Log.IsEnabled()) Trace($"ReleaseStream: _availableRequestStreamsCount = {_availableRequestStreamsCount}");
+                ++_availableRequestStreamsCount;


We'll have to signal the _availableStreamsWaiter from here as well because StreamsAvailableCallback may not be called for a while if a bunch of streams got consumed by requests that were immediately canceled and released their streams.

MihaZupan · 2024-05-23T17:37:56Z

src/libraries/System.Net.Quic/ref/System.Net.Quic.cs

    }
+    public delegate void QuicConnectionStreamsAvailableCallback(System.Net.Quic.QuicConnection connection, int bidirectionalStreamsCountIncrement, int unidirectionalStreamsCountIncrement);


More of an API review question, but is there any chance we'll want to expose more info here such that we'd want the arguments to be a struct instead?

We have only stream count related info, technically the transport sends MAX_STREAM_ID and separately for Uni/Bi directional streams.
The only think we could expose are different ways to express the new stream limit, which is part of alternative design in #101534

MihaZupan · 2024-05-23T17:46:07Z

src/libraries/System.Net.Quic/src/System/Net/Quic/QuicStream.cs

+    /// Provided via <see cref="StartAsync(Action{QuicStreamType}, CancellationToken)" /> from <see cref="QuicConnection" /> so that <see cref="QuicStream"/> can decrement its available stream count field.
+    /// When <see cref="HandleEventStartComplete(ref START_COMPLETE_DATA)">START_COMPLETE</see> arrives it gets invoked and unset back to <c>null</c> to not to hold any unintended reference to <see cref="QuicConnection"/>.
+    /// </summary>
+    private Action<QuicStreamType>? _decrementAvailableStreamCount;


Is this functionally the same as if we instead temporarily stored a QuicConnection and exposed the decrement function there as internal?

MihaZupan · 2024-05-23T17:50:54Z

src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs

@@ -603,6 +674,15 @@ private unsafe int HandleEventPeerStreamStarted(ref PEER_STREAM_STARTED_DATA dat
        data.Flags |= QUIC_STREAM_OPEN_FLAGS.DELAY_ID_FC_UPDATES;
        return QUIC_STATUS_SUCCESS;
    }
+    private unsafe int HandleEventStreamsAvailable(ref STREAMS_AVAILABLE_DATA data)


Can we get MsQuic to expose increments instead of current counts?
(presumably, that's the data that they're reacting to that triggered these events in the first place?)

That'd let us drop the whole DecrementAvailableStreamCount dance

I like this idea. I can try that. It would also resolve the issue with the _decrementAvailableStreamCount callback. However, I'll not push on adding this to MsQuic, until we have the API approved, we might end up with MAX_STREAM_ID or different value being reported by the callback...

MihaZupan · 2024-05-23T17:58:01Z

src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs

@@ -427,7 +498,7 @@ public async ValueTask<QuicStream> OpenOutboundStreamAsync(QuicStreamType type,
                NetEventSource.Info(this, $"{this} New outbound {type} stream {stream}.");
            }

-            await stream.StartAsync(cancellationToken).ConfigureAwait(false);
+            await stream.StartAsync(DecrementAvailableStreamCount, cancellationToken).ConfigureAwait(false);


Using DecrementAvailableStreamCount directly here will allocate a new object for every stream.
We could cache a single Action<QuicStreamType> instance on the connection.

MihaZupan · 2024-05-23T18:24:26Z

...m.Net.Http/src/System/Net/Http/SocketsHttpHandler/ConnectionPool/HttpConnectionPool.Http3.cs

+                // The new connection could not handle even one request, either because it shut down before we could use it for any requests,
+                // or because it immediately set the max concurrent streams limit to 0.
+                // We don't want to get stuck in a loop where we keep trying to create new connections for the same request.
+                // So, treat this as a connection failure.


I don't think this is right for HTTP/3.

With HTTP/2, this would only happen if the connection was already closed as it otherwise always starts with a non-zero amount of available streams.

With HTTP/3, _availableRequestStreamsCount may still be 0 at this point, especially given that StreamsAvailableCallback is queued to the thread pool and may therefore signal the initial available streams after we hand the connection to the pool and reach this block.
In which case we'd be throwing away a good connection and failing a request.

MihaZupan · 2024-05-23T18:27:01Z

...m.Net.Http/src/System/Net/Http/SocketsHttpHandler/ConnectionPool/HttpConnectionPool.Http3.cs

+                connectionException = e is OperationCanceledException oce && oce.CancellationToken == cts.Token && !waiter.CancelledByOriginatingRequestCompletion ?
+                    CreateConnectTimeoutException(oce) :
+                    e;
+                // If the connection hasn't been initialized with QuicConnection there's no need to dispose it.


This assumes that InitQuicConnection may never throw, right?

MihaZupan · 2024-05-23T18:33:56Z

src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs

+    /// Occurres when an additional stream capacity has been released by the peer. Corresponds to receiving MAX_STREAMS frame.
+    /// </summary>
+    public event QuicConnectionStreamsAvailableEventHandler? StreamsAvailable;
+    private async void OnStreamsAvailable(int bidirectionalStreamsCountIncrement, int unidirectionalStreamsCountIncrement)


Gag reflex whenever I see async void 😃
E.g. it could be a regular async Task with the caller doing _ = OnStreamsAvailable(), like we do for InjectNewHttp3ConnectionAsync.

It's probably fine in this case though.

dotnet-issue-labeler bot added area-System.Net.Http new-api-needs-documentation labels Apr 25, 2024

dotnet-policy-service bot assigned ManickaP Apr 25, 2024

ManickaP added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 25, 2024

ManickaP requested a review from a team April 25, 2024 08:30

ManickaP force-pushed the h3-mul-conn branch from 97fdf7a to e193fce Compare April 25, 2024 08:32

ManickaP mentioned this pull request Apr 25, 2024

[API Proposal]: [QUIC] Support managing available streams on QuicConnection #101534

Open

rzikm reviewed Apr 25, 2024

View reviewed changes

MihaZupan reviewed Apr 25, 2024

View reviewed changes

ManickaP force-pushed the h3-mul-conn branch from 06fab49 to c9ef439 Compare May 14, 2024 12:29

ManickaP added 3 commits May 14, 2024 14:29

QuicConnection StreamsAvailable properties and event handler

4b055a8

EnableHttp3MultipleConnections property

b1e4427

H3 connection pool

dc4f98e

ManickaP and others added 4 commits May 14, 2024 14:29

Fixed unused methods.

c76fefe

Update src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpH…

a8013da

…andler/Http3Connection.cs Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com>

Fix release reserved stream count once it's opened.

76d2232

Available streams count is thread safe

c9ef439

build-analysis bot mentioned this pull request May 14, 2024

tracing/eventpipe/providervalidation/providervalidation/providervalidation.cmd test failure #101759

Open

Move StreamsAvailable callback into connection options, remove count …

17df37d

…properties

build-analysis bot mentioned this pull request May 15, 2024

Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488

Open

ManickaP force-pushed the h3-mul-conn branch from 71869db to 3b21bea Compare May 16, 2024 09:21

HTTP adjustments to StreamsAvailable callback in options

3b21bea

ManickaP force-pushed the h3-mul-conn branch from 2423f16 to a8d83ab Compare May 16, 2024 13:40

Comments about multiple connections, including mention of being again…

a8d83ab

…st RFC

ManickaP added a commit to dotnet/dotnet-api-docs that referenced this pull request May 16, 2024

[HTTP/2] MultipleConnections

8200754

dotnet/runtime#101531 (comment)

ManickaP added a commit to dotnet/dotnet-api-docs that referenced this pull request May 16, 2024

[HTTP/2] MultipleConnections update

54e731d

dotnet/runtime#101531 (comment)

ManickaP mentioned this pull request May 16, 2024

[HTTP/2] MultipleConnections update dotnet/dotnet-api-docs#9921

Merged

MihaZupan reviewed May 16, 2024

View reviewed changes

...m.Net.Http/src/System/Net/Http/SocketsHttpHandler/ConnectionPool/HttpConnectionPool.Http3.cs Outdated Show resolved Hide resolved

src/libraries/System.Net.Quic/ref/System.Net.Quic.cs Outdated Show resolved Hide resolved

ManickaP added a commit to dotnet/dotnet-api-docs that referenced this pull request May 16, 2024

[HTTP/2] MultipleConnections update (#9921)

cf901c7

dotnet/runtime#101531 (comment)

This was referenced May 20, 2024

System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558

Open

SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts dotnet/dnceng#2496

Open

Miha's Feedback: H/3 authority evaluation, user callback try-catch

d356cea

ManickaP force-pushed the h3-mul-conn branch from b068589 to d356cea Compare May 22, 2024 13:36

ManickaP added 2 commits May 23, 2024 11:35

Fix releasing stream

0e80ae5

Added logging for stream counts

d8ca92c

MihaZupan reviewed May 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HTTP/3] Support for HTTP/3 multiple connections #101531

[HTTP/3] Support for HTTP/3 multiple connections #101531

ManickaP commented Apr 25, 2024 •

edited

dotnet-issue-labeler bot commented Apr 25, 2024

ManickaP commented Apr 25, 2024 •

edited

MihaZupan Apr 25, 2024

ManickaP May 13, 2024

MihaZupan May 23, 2024

ManickaP May 27, 2024

ManickaP commented May 16, 2024

MihaZupan left a comment

MihaZupan May 23, 2024

ManickaP May 27, 2024

MihaZupan May 23, 2024

MihaZupan May 23, 2024

ManickaP May 27, 2024

MihaZupan May 23, 2024

MihaZupan May 23, 2024

ManickaP May 27, 2024

MihaZupan May 23, 2024

MihaZupan May 23, 2024 •

edited

MihaZupan May 23, 2024

MihaZupan May 23, 2024

	private async void OnStreamsAvailable(int bidirectionalStreamsCountIncrement, int unidirectionalStreamsCountIncrement)
	private async Task OnStreamsAvailable(int bidirectionalStreamsCountIncrement, int unidirectionalStreamsCountIncrement)

		}
		public delegate void QuicConnectionStreamsAvailableCallback(System.Net.Quic.QuicConnection connection, int bidirectionalStreamsCountIncrement, int unidirectionalStreamsCountIncrement);

[HTTP/3] Support for HTTP/3 multiple connections #101531

Are you sure you want to change the base?

[HTTP/3] Support for HTTP/3 multiple connections #101531

Conversation

ManickaP commented Apr 25, 2024 • edited

dotnet-issue-labeler bot commented Apr 25, 2024

ManickaP commented Apr 25, 2024 • edited

main

PR, multiple H3 connections OFF

PR, multiple H3 connections ON

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ManickaP commented May 16, 2024

MihaZupan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MihaZupan May 23, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ManickaP commented Apr 25, 2024 •

edited

ManickaP commented Apr 25, 2024 •

edited

MihaZupan May 23, 2024 •

edited