Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unstable test DataGridView_OnColumnHeadersHeightChanged_InvokeWithHandle_CallsColumnHeadersHeightChanged #11323

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented May 8, 2024

Related #11322

Proposed changes

  • Add judgment logic to the x86 test to skip the following test scenarios System.Windows.Forms.Tests.DataGridViewTests.DataGridView_OnColumnHeadersHeightChanged_InvokeWithHandle_CallsColumnHeadersHeightChanged(columnHeadersWidthSizeMode: DisableResizing, columnHeadersVisible: True, eventArgs: EventArgs { }) and System.Windows.Forms.Tests.DataGridViewTests.DataGridView_OnColumnHeadersHeightChanged_InvokeWithHandle_CallsColumnHeadersHeightChanged(columnHeadersWidthSizeMode: DisableResizing, columnHeadersVisible: True, eventArgs: null)
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner May 8, 2024 02:57
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.27388%. Comparing base (8d62cf5) to head (5cc4bae).
Report is 12 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11323         +/-   ##
===================================================
+ Coverage   74.24748%   74.27388%   +0.02640%     
===================================================
  Files           3022        3025          +3     
  Lines         626296      626861        +565     
  Branches       46702       46742         +40     
===================================================
+ Hits          465009      465594        +585     
- Misses        157891      157925         +34     
+ Partials        3396        3342         -54     
Flag Coverage Δ
Debug 74.27388% <75.00000%> (+0.02640%) ⬆️
integration 17.99487% <ø> (-0.27364%) ⬇️
production 47.00204% <ø> (+0.07804%) ⬆️
test 96.99415% <75.00000%> (-0.04314%) ⬇️
unit 43.95003% <ø> (+0.06656%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label May 8, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 11, 2024
@LeafShi1 LeafShi1 merged commit 9f8f671 into dotnet:main May 11, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview5 milestone May 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants