Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate: unit-student-enrolment-modal #577

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

AnthonyP128
Copy link

@AnthonyP128 AnthonyP128 commented Aug 19, 2022

Description

This migration converts AngularJS to Angular. The component involved is the unit-student-enrolment-modal component

Component

Testing Checklist:

Before
Screen Shot 2022-08-19 at 7 02 47 pm

After
Screen Shot 2022-08-31 at 1 49 32 pm

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

@AnthonyP128 AnthonyP128 changed the title new: create initial files for migration of unit-student-enrollment-… migrate: unit-student-enrolment-modal Aug 31, 2022
@jakerenzella
Copy link
Member

Look good, ready for eval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants