Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Unit student enrolment modal coffee #847

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

s223749059
Copy link
Contributor

@s223749059 s223749059 commented May 14, 2024

Description

Migrate the unit-student-enrolment-modal component from CoffeeScript and Angular.js to TypeScript and Angular. The component is used at unit-students-editor component. It creates a dialog to enrol a student with information about studentId and campus. The action can be performed under aconvenor and aadmin account privileges.

How Has This Been Tested?

  • First, log in as aconvenor or aadmin acount.
  • Under the Administration section, select Units.
  • After choosing a specific unit name, select the Students tab.
  • In the bottom of the webpage, click on the Enrol icon to open a dialog. Users can enter a studentId and select the campus location.
  • By clicking save, a success message or an error handling will be displayed in the top right corner of the webpage. It indicates the enrolment status. After that, users can filter the studentID to verify the action.

Before:

sit782_migrate_unit_student_enrolment_modal_doubtfire_lms_before

After:

sit782_migrate_unit_student_enrolment_modal_doubtfire_lms_after
  • Successful enrolment message:
sit782_migrate_unit_student_enrolment_modal_doubtfire_lms_enrol_message
  • Error handling:
sit782_migrate_unit_student_enrolment_modal_doubtfire_lms_error_handling

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant