Bug 735982 - [PATCH] Fix potential allocation of huge memory amount d…

…ue to type overflow in src/lodepng.cpp
doxygen · Sep 23, 2014 · 30870ef · 30870ef
1 parent 68aa8c2
commit 30870ef
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/lodepng.cpp b/src/lodepng.cpp
@@ -4125,9 +4125,12 @@ unsigned LodePNG_loadFile(unsigned char** out, size_t* outsize, const char* file
   rewind(file);
 
   /*read contents of the file into the vector*/
-  *outsize = 0;
-  *out = (unsigned char*)malloc((size_t)size);
-  if(size && (*out)) (*outsize) = fread(*out, 1, (size_t)size, file);
+  if (size>0)
+  {
+    *outsize = 0;
+    *out = (unsigned char*)malloc((size_t)size);
+    if(size && (*out)) (*outsize) = fread(*out, 1, (size_t)size, file);
+  }
 
   fclose(file);
   if(!(*out) && size) return 80; /*the above malloc failed*/