Skip to content

Commit

Permalink
Fixed potential crash caused by overloading the variadic warn function
Browse files Browse the repository at this point in the history
  • Loading branch information
Dimitri van Heesch committed Jan 18, 2014
1 parent ac81313 commit 31505eb
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/message.cpp
Expand Up @@ -172,7 +172,7 @@ void warn(const char *file,int line,const char *fmt, ...)
va_end(args);
}

void warn(const char *file,int line,const char *fmt,va_list args)
void va_warn(const char *file,int line,const char *fmt,va_list args)
{
do_warn("WARNINGS", file, line, warning_str, fmt, args);
}
Expand Down
2 changes: 1 addition & 1 deletion src/message.h
Expand Up @@ -23,7 +23,7 @@

extern void msg(const char *fmt, ...);
extern void warn(const char *file,int line,const char *fmt, ...);
extern void warn(const char *file,int line,const char *fmt, va_list args);
extern void va_warn(const char *file,int line,const char *fmt, va_list args);
extern void warn_simple(const char *file,int line,const char *text);
extern void warn_undoc(const char *file,int line,const char *fmt, ...);
extern void warn_doc_error(const char *file,int line,const char *fmt, ...);
Expand Down
4 changes: 2 additions & 2 deletions src/template.cpp
Expand Up @@ -1713,7 +1713,7 @@ void TemplateContextImpl::warn(const char *fileName,int line,const char *fmt,...
{
va_list args;
va_start(args,fmt);
::warn(fileName,line,fmt,args);
va_warn(fileName,line,fmt,args);
va_end(args);
m_engine->printIncludeContext(fileName,line);
}
Expand Down Expand Up @@ -3342,7 +3342,7 @@ void TemplateParser::warn(const char *fileName,int line,const char *fmt,...) con
{
va_list args;
va_start(args,fmt);
::warn(fileName,line,fmt,args);
va_warn(fileName,line,fmt,args);
va_end(args);
m_engine->printIncludeContext(fileName,line);
}
Expand Down

0 comments on commit 31505eb

Please sign in to comment.