Pass strings as const references.

It has refcounting, copy-on-write and all, but this is still better.
doxygen · Nov 19, 2017 · ebf75c1 · ebf75c1
1 parent d8001ef
commit ebf75c1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/util.cpp b/src/util.cpp
@@ -7177,7 +7177,7 @@ void addCodeOnlyMappings()
   updateLanguageMapping(".sql",   "sql");
 }
 
-SrcLangExt getLanguageFromFileName(const QCString fileName)
+SrcLangExt getLanguageFromFileName(const QCString& fileName)
 {
   int i = fileName.findRev('.');
   if (i!=-1) // name has an extension

diff --git a/src/util.h b/src/util.h
@@ -384,7 +384,7 @@ QCString stripLeadingAndTrailingEmptyLines(const QCString &s,int &docLine);
 //                         const QCString &anchor="");
 
 bool updateLanguageMapping(const QCString &extension,const QCString &parser);
-SrcLangExt getLanguageFromFileName(const QCString fileName);
+SrcLangExt getLanguageFromFileName(const QCString& fileName);
 void initDefaultExtensionMapping();
 void addCodeOnlyMappings();