Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release GitHub actions #336

Draft
wants to merge 7 commits into
base: v2
Choose a base branch
from
Draft

Add release GitHub actions #336

wants to merge 7 commits into from

Conversation

klwetstone
Copy link
Collaborator

@klwetstone klwetstone commented Dec 1, 2023

closes #317

Add GitHub actions to publish on release

Do not merge - #315 is needed first. After transfer, the repo should automatically have access to the PyPI secrets needed by release.yml

ccds.__version__

Users can now see the version of ccds after importing (ccds.__version__). However, the project name is different than the module name. This means that in version.py, we have to hard code the project name with:

__version__ = importlib_metadata.version("cookiecutter-data-science")

Instead of using:

__version__ = importlib_metadata.version(__name__.split(".", 1)[0])

Docs

This PR does not include versioning for docs (eg. with a "Build docs" job). That is tracked separately in #334

Copy link
Collaborator

@jayqi jayqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants