Core rewrite #3
Open
Core rewrite #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {Object} [options = {}] Specifies optional blog settings. | ||
| */ | ||
| var Blogit = module.exports = function Blogit(options) { | ||
| options = Object(options) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a core rewrite that I worked on today. It's quite a significant departure from the current design, so I completely understand if you'd rather not merge this. The changes include:
post.js,posts.js, andrender.jshave been consolidated intoindex.js.Blogit#getPost, as it is entirely synchronous.Blogitconstructor that accepts anoptionsobject.blogitexecutable replacesblog.js. The logic for creating the HTTP server has been moved intoBlogit#createBlog.asyncdependency has been replaced withasync-it, which supports parallel mapping (async's implementation is serial).No new features have been added yet.