Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled gaussian filtering on GOES16/17 data (point2grid) #1291

Closed
17 of 18 tasks
hsoh-u opened this issue Mar 31, 2020 · 2 comments
Closed
17 of 18 tasks

Enabled gaussian filtering on GOES16/17 data (point2grid) #1291

hsoh-u opened this issue Mar 31, 2020 · 2 comments
Assignees
@lindsayrblank @hsoh-u @JohnHalleyGotway
Labels
MET: Probability Verifcation type: enhancement Improve something that it is currently doing
Projects
MET-9.1-beta1 (4/29/20)
Milestone
MET 9.1

Comments

@hsoh-u
Copy link
Collaborator

hsoh-u commented Mar 31, 2020 •
edited by JohnHalleyGotway

Describe the Task

The Gaussian filtering at point2grid was not enabled GOES16/17 data. The test case (METplus) will need the Gaussian filtering for GOES16/17 data.

Time Estimate

1 project day

Relevant Deadlines

Funding Source

2760811 for GOES16

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: Howard Soh
  • Select scientist(s) or no scientist required: Lindsay Blank

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s) NA

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones
  • Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop, listing the <Issue Number> in the title.
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@hsoh-u hsoh-u added type: enhancement Improve something that it is currently doing component: application code labels Mar 31, 2020
@hsoh-u hsoh-u added this to the MET 9.1 milestone Mar 31, 2020
@hsoh-u hsoh-u added this to To do in MET-9.1-beta1 (4/29/20) via automation Mar 31, 2020
@JohnHalleyGotway JohnHalleyGotway moved this from To do to In progress in MET-9.1-beta1 (4/29/20) Mar 31, 2020
@JohnHalleyGotway JohnHalleyGotway moved this from In progress to Pull request review in MET-9.1-beta1 (4/29/20) Apr 22, 2020
hsoh-u added a commit that referenced this issue Apr 23, 2020
@hsoh-u
#1291 -prob_cat_thresh requiers an equality or inequality symbol
077f778
hsoh-u added a commit that referenced this issue Apr 23, 2020
@hsoh-u
#1291 Changed datatype of prob_cat_thresh to SingleThresh
214abf4
hsoh-u added a commit that referenced this issue Apr 23, 2020
@hsoh-u
#1291 Changed command line argument of -prob_cat_thresh
1482218
@hsoh-u
Copy link
Collaborator Author

hsoh-u commented Apr 23, 2020

Additional modifications to change double type "prob_cat_thresh" to SingleThresh type.:

  • met/doc/MET_Users_Guide/Reformat_Point/MET_Users_Guide_Reformat_Point.lyx
  • met/src/tools/other/point2grid/point2grid.cc
  • test/xml/unit_point2grid.xml

hsoh-u added a commit that referenced this issue Apr 24, 2020
@hsoh-u
#1291 Changed usage messages for the consistency
9528633
JohnHalleyGotway added a commit that referenced this issue Apr 24, 2020
@hsoh-u @JohnHalleyGotway
feature 1291 develop gaussian to goes (#1308)
2747852 
* #1291 Enabled gaussian to GOES. Added attributes for gaussian congig

* #1291 Added point2grid_GOES_16_AOD_TO_G212_GAUSSIAN

* #1291 -prob_cat_thresh requiers an equality or inequality symbol

* #1291 Changed datatype of prob_cat_thresh to SingleThresh

* #1291 Changed command line argument of -prob_cat_thresh

* #1291 Changed usage messages for the consistency

* Update met/src/tools/other/point2grid/point2grid.cc

* Update met/src/tools/other/point2grid/point2grid.cc

* Update met/src/tools/other/point2grid/point2grid.cc

Co-authored-by: johnhg <johnhg@ucar.edu>
@JohnHalleyGotway JohnHalleyGotway moved this from Pull request review to Done in MET-9.1-beta1 (4/29/20) Apr 24, 2020
@JohnHalleyGotway JohnHalleyGotway moved this from Done to In progress in MET-9.1-beta1 (4/29/20) Apr 24, 2020
@JohnHalleyGotway JohnHalleyGotway self-assigned this Apr 24, 2020
@JohnHalleyGotway
Copy link
Collaborator

As discussed via Slack, update the NetCDF output variable names to include the threshold used to define the probabilities.

@JohnHalleyGotway JohnHalleyGotway moved this from In progress to Pull request review in MET-9.1-beta1 (4/29/20) Apr 24, 2020
JohnHalleyGotway added a commit that referenced this issue Apr 24, 2020
@JohnHalleyGotway @hsoh-u
Feature 1291 develop gaussian to goes (#1314)
38a443f 
* #1291 Enabled gaussian to GOES. Added attributes for gaussian congig

* #1291 Added point2grid_GOES_16_AOD_TO_G212_GAUSSIAN

* #1291 -prob_cat_thresh requiers an equality or inequality symbol

* #1291 Changed datatype of prob_cat_thresh to SingleThresh

* #1291 Changed command line argument of -prob_cat_thresh

* #1291 Changed usage messages for the consistency

* Update met/src/tools/other/point2grid/point2grid.cc

* Update met/src/tools/other/point2grid/point2grid.cc

* Update met/src/tools/other/point2grid/point2grid.cc

* Per #1271, include the prob_cat_thresh in the output variable names.

* Per #1271, redirect the output from the unit_point2grid.xml tests from the regrid output directory to the point2grid directory to make it easier to find.

Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@kiowa.rap.ucar.edu>
@JohnHalleyGotway JohnHalleyGotway moved this from Pull request review to Done in MET-9.1-beta1 (4/29/20) Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lindsayrblank lindsayrblank

@hsoh-u hsoh-u

@JohnHalleyGotway JohnHalleyGotway

Labels
MET: Probability Verifcation type: enhancement Improve something that it is currently doing
Projects
No open projects
MET-9.1-beta1 (4/29/20)
  
Done
Milestone
MET 9.1
Development

No branches or pull requests
4 participants
@lindsayrblank @jprestop @hsoh-u @JohnHalleyGotway