Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1291 develop gaussian to goes #1314

Merged
merged 12 commits into from Apr 24, 2020

Conversation

JohnHalleyGotway
Copy link
Collaborator

Howard, please review these tweaks for point2grid.
Include the threshold in the output NetCDF probability variable names.
Redirect unit_point2grid.xml output into a new point2grid output directory.
The newly updated output from unit_point2grid.xml can be seen in kiowa:/d1/projects/MET/MET_pull_requests/met-9.1_beta1/feature_1291/MET-feature_1291_develop_gaussian_to_GOES/test/test_output/point2grid.
Added a note to the Google doc to update the Sphinx documentation:
https://docs.google.com/document/d/1nCPBzu0eYognWWDHyocF3riuzydkF01N87cDWG3Bu0g/edit

@JohnHalleyGotway JohnHalleyGotway added this to the MET 9.1 milestone Apr 24, 2020
@JohnHalleyGotway JohnHalleyGotway added this to Pull request review in MET-9.1-beta1 (4/29/20) Apr 24, 2020
Copy link
Collaborator

@hsoh-u hsoh-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The probability variable name includes criteria. The output directory of unit test was corrected. too.
I tested this at dakota and approve the merge into develop branch

@hsoh-u
Copy link
Collaborator

hsoh-u commented Apr 24, 2020

Resolved a conflict and merged into develop branch

@JohnHalleyGotway JohnHalleyGotway merged commit 38a443f into develop Apr 24, 2020
MET-9.1-beta1 (4/29/20) automation moved this from Pull request review to Done Apr 24, 2020
@JohnHalleyGotway JohnHalleyGotway deleted the feature_1291_develop_gaussian_to_GOES branch April 24, 2020 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants