Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
I found a problem with the code changes for #1527. In command_line.cc, do_verbosity() and do_log() only parsed the LAST instance of the -v and -log options, respectively. If they are used more than once on the command line, the extra ones remain in the list but the calling application doesn't know how to parse them. Fix this by having the do_verbosity() and do_log() parse and remove all of them from the command line object in the order provided.
Tested by running:
Prior to the fix, this errors out. After the fix, it runs fine. This matches the behavior in the main_v9.1 branch.
Recommend testing for the reviewer to perform, including the location of input datasets:
Review code changes. Run a couple of tests to confirm that the fix makes -v and -log work the same as they do in MET version 9.1.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
After merging, should the reviewer DELETE the feature branch from GitHub? [Yes]
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone