-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update develop-ref after #1681 and #1676 #1683
Commits on Jan 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 04e3397 - Browse repository at this point
Copy the full SHA 04e3397View commit details
Commits on Feb 1, 2021
-
Per #1644, no actual code changes here. Just formatting and spacing. …
…For example, replace double ;; with single ;'
Configuration menu - View commit details
-
Copy full SHA for 45a16ef - Browse repository at this point
Copy the full SHA 45a16efView commit details -
Per #1644, FOUND THE BUG! It's a copy/paste error. We had var_name_ma…
…p.end() that should be def_var_name_map.end(). Fixing that gets rid of the runtime hang.'
Configuration menu - View commit details
-
Copy full SHA for b260607 - Browse repository at this point
Copy the full SHA b260607View commit details -
Per #1643, redefine the contents of the existing AREA_RATIO output co…
…lumn from MODE. Define it as FCST/OBS object area instead of min/max. Update the User's Guide to note the change and also clarify that the MTD VOLUME_RATIO output really is FCST/OBS. (#1650)
Configuration menu - View commit details
-
Copy full SHA for 1186ec3 - Browse repository at this point
Copy the full SHA 1186ec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 502c912 - Browse repository at this point
Copy the full SHA 502c912View commit details
Commits on Feb 2, 2021
-
The mode_conv.pl logic was slightly broken. MET PR #1650 should have …
…broken the NB but it did not. Turns out the diffing logic is NOT properly distinguishing between single and pair object lines. It does this by looking for an underscore in the OBJECT_ID column. When we added FCST_UNITS and OBS_UNITS, that shifted OBJECT_ID up 2 spots, but the code was still checking the (0-based) 20th column instead of the 22nd. Fixing this now and will rerun NB20210202 to confirm it works again.
John Halley Gotway committedFeb 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 3e8c422 - Browse repository at this point
Copy the full SHA 3e8c422View commit details
Commits on Feb 3, 2021
-
The diffing logic for MODE pair lines still was not correct. We'd add…
…ed the ASPECT_DIFF and CURVATURE_RATIO columns a while ago, but they were missing from the diff logic. This logic really is not good. We need to make it more robust, reading the version-specific header columns from a table file instead of hard-coding them!
John Halley Gotway committedFeb 3, 2021 Configuration menu - View commit details
-
Copy full SHA for e1f691c - Browse repository at this point
Copy the full SHA e1f691cView commit details
Commits on Feb 5, 2021
-
* Per #1653, update plot_cnt.R and plot_mpr.R to remove the version-specific header columns. * Per #1653, nice enhancments to these Rscripts to make them more independent of the MET version number. * Per #1653, more tweaks * Per #1653, if no input files are provided, error out with a useful message. * Per #1653, while the scripts ran fine using R 4.0.2 on my Mac, they fail on eyewall using R 3.4.0. Adding as.character() to get past that error.
Configuration menu - View commit details
-
Copy full SHA for 121964b - Browse repository at this point
Copy the full SHA 121964bView commit details
Commits on Feb 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c344ff1 - Browse repository at this point
Copy the full SHA c344ff1View commit details
Commits on Feb 9, 2021
-
#1630 Display a warning instead of error message with invalid variabl…
…e if the input data is empty
Howard Soh committedFeb 9, 2021 Configuration menu - View commit details
-
Copy full SHA for 4c39427 - Browse repository at this point
Copy the full SHA 4c39427View commit details -
Merge remote-tracking branch 'origin/develop' into feature_1630_point…
…2grid_hang
Howard Soh committedFeb 9, 2021 Configuration menu - View commit details
-
Copy full SHA for ba129f0 - Browse repository at this point
Copy the full SHA ba129f0View commit details -
Merge pull request #1660 from dtcenter/feature_1630_point2grid_hang
Feature 1630 point2grid hang
Configuration menu - View commit details
-
Copy full SHA for 68e7389 - Browse repository at this point
Copy the full SHA 68e7389View commit details
Commits on Feb 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 530a874 - Browse repository at this point
Copy the full SHA 530a874View commit details
Commits on Feb 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4c9ecde - Browse repository at this point
Copy the full SHA 4c9ecdeView commit details
Commits on Feb 17, 2021
-
* Per #1450, add new ECNT columns for Hersback CRPS. Still need to actually compute the stats though. * Per #1450, update NumArray functions to only sort if the data is not yet sorted. And check for bad data when computing the standard deviation. * Per #1450, add code to compute the empirical CRPS value. * Per #1450, large change to the new output for the empirical CRPS. In order to aggregate decomposed empirical CRPS reliability and potential correctly, we'd need to write (n+1)*2 additional columns. While the empirical crps can be aggregated as a weighted mean, the decomposition cannot. It just isn't feasible to do this in the ECNT line type. If this reliability and potential really are required, recommend that we add an entirely new CRPS line type instead of tacking onto ECNT. These changes simply remove reliabilit and potential from the output. * Per #1450 and #1451, replacing single CRPS_CLIMO column with CRPSCL and CRPSCL_EMP which will be needed for #1451. * Per #1450, delete temp files I'd accidentally committed. * Per #1450, update the user's guide with CRPS updates. * Fix bug replacing crpss_emp with crpss_gaus.
Configuration menu - View commit details
-
Copy full SHA for 11a5419 - Browse repository at this point
Copy the full SHA 11a5419View commit details
Commits on Feb 18, 2021
-
Howard Soh committed
Feb 18, 2021 Configuration menu - View commit details
-
Copy full SHA for 25e7d4f - Browse repository at this point
Copy the full SHA 25e7d4fView commit details -
#1657 Corrected 1 second offset by the precision error
Howard Soh committedFeb 18, 2021 Configuration menu - View commit details
-
Copy full SHA for 9b8ccf2 - Browse repository at this point
Copy the full SHA 9b8ccf2View commit details -
Howard Soh committed
Feb 18, 2021 Configuration menu - View commit details
-
Copy full SHA for b72f0b6 - Browse repository at this point
Copy the full SHA b72f0b6View commit details -
#1657 Read the time from "bounds" attribute and set the max value fro…
…m the bounds time variable
Howard Soh committedFeb 18, 2021 Configuration menu - View commit details
-
Copy full SHA for 596562a - Browse repository at this point
Copy the full SHA 596562aView commit details -
#1657 Corrected 1 second offset by the precision error
Howard Soh committedFeb 18, 2021 Configuration menu - View commit details
-
Copy full SHA for 3668fa4 - Browse repository at this point
Copy the full SHA 3668fa4View commit details
Commits on Feb 22, 2021
-
Merge pull request #1674 from dtcenter/feature_1657_bounds_attribute
Feature 1657 bounds attribute
Configuration menu - View commit details
-
Copy full SHA for 5e3d6d1 - Browse repository at this point
Copy the full SHA 5e3d6d1View commit details
Commits on Feb 23, 2021
-
Per #1439, add check_mask_names() utility function which errors out i…
…f the list of masking region names is non-unique. Update Point-Stat and Grid-Stat to call it. (#1679)
Configuration menu - View commit details
-
Copy full SHA for 6231c1e - Browse repository at this point
Copy the full SHA 6231c1eView commit details
Commits on Feb 24, 2021
-
* Per #1450, add new ECNT columns for Hersback CRPS. Still need to actually compute the stats though. * Per #1450, update NumArray functions to only sort if the data is not yet sorted. And check for bad data when computing the standard deviation. * Per #1450, add code to compute the empirical CRPS value. * Per #1450, large change to the new output for the empirical CRPS. In order to aggregate decomposed empirical CRPS reliability and potential correctly, we'd need to write (n+1)*2 additional columns. While the empirical crps can be aggregated as a weighted mean, the decomposition cannot. It just isn't feasible to do this in the ECNT line type. If this reliability and potential really are required, recommend that we add an entirely new CRPS line type instead of tacking onto ECNT. These changes simply remove reliabilit and potential from the output. * Per #1450 and #1451, replacing single CRPS_CLIMO column with CRPSCL and CRPSCL_EMP which will be needed for #1451. * Per #1450, delete temp files I'd accidentally committed. * Per #1450, update the user's guide with CRPS updates. * Per #1451, instead of computing the climo crps on the fly, compute and store it separately for each point. * Per #1451, the ECNT line type will no longer be written separately for each CDF bin. Removing the bin-related arguments from the write_ecnt functions. * Per #1451, the climo_cdf.write_bins option no longer applies. Since Ensemble-Stat will no longer compute stats separately for each climo bin, I'm removing the reference to write_bins from the Ensemble-Stat config files. * Per #1451, compute and store the climo CRPS for each point. Also, break apart the normal climo computation into separate functions for crps, ign, and pit. * Per #1451, update Ensemble-Stat logic to no longer subset pairs into climo CDF bins. We had done this to be consistent with the use of climo data in point and grid-stat. But this change to the handling of climo data is consitent with the NOAA/EMC approach. * Per #1451, split out the setting of climo CDF thresholds into a separate function so that it can also be called by stat-analysis. * Per #1451, in the Ensemble-Stat ORANK line type, rename CLIMO to CLIMO_MEAN and add a CLIMO_STDEV column. * Per #1451, also need to update gsidens2orank to write a climo_stdev column. * Per #1451, switch from constant pointer to ClimoCDFInfo object to a copy to make the logic of doing this in Stat-Analysis a little easier. * Per #1451, the HiRA method in Point-Stat computes an ECNT output line type. Needed to call set_climo_cdf() there so that we know how many climo values to use when computing the empirical climo CRPS. * Per #1451, need to store climo_cdf for both grid and point verification. * Per #1451, update to write the CLIMO_STDEV header column for the ORANK line type. * Per #1451, in Ensemble-Stat when doing point verification, check for empty OBS_UNIT string and write NA instead. * Per #1451, update unit tests by enhancing the climatology call to Ensemble-Stat to also include point verification. Tweak the Ensemble-Stat cofiguration for that and also add a call to pb2nc to prepare the point observations for use. * Per #1450, added a new section to the Ensemble-Stat chapter describing how climo mean/stdev are used in the computation of the skill scores. * Update ensemble-stat.rst Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8fb5a47 - Browse repository at this point
Copy the full SHA 8fb5a47View commit details -
#1677 Update the refence time (from time_bnds variable) (#1680)
Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for dafcd34 - Browse repository at this point
Copy the full SHA dafcd34View commit details -
Feature 1135 stat_analysis (#1681)
* Per #1135, add fcst/obs_init/valid_inc/exc options for STAT-Analysis jobs. * Per #1135, update all the STATAnalysis config files to include entries for the new fcst/obs_init/valid_inc/exc options. * Per #1135, add documentation for fcst/obs_init/valid_inc/exc options to the STAT-Analysis chapter. Also, clarify the description for the existing options. * Per #1135, adding another call to stat_analysis to check the time filtering options. * Per #1135, just renaming stat_analysis output file. * Apply suggestions from code review Co-authored-by: jprestop <jpresto@ucar.edu> Co-authored-by: John Halley Gotway <johnhg@kiowa.rap.ucar.edu> Co-authored-by: jprestop <jpresto@ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for 804d026 - Browse repository at this point
Copy the full SHA 804d026View commit details
Commits on Feb 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cf606da - Browse repository at this point
Copy the full SHA cf606daView commit details