Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1731 docs #1781

Merged
merged 10 commits into from May 7, 2021
Merged

Feature 1731 docs #1781

merged 10 commits into from May 7, 2021

Conversation

j-opatz
Copy link
Contributor

@j-opatz j-opatz commented May 7, 2021

Pull Request Testing

  • Describe testing already performed for these changes:
    This branch was already merged, but additional documentation updates (tc_pairs, grid-diag) were added since the merge.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
    Quick language, spelling check should suffice.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    These are only documentation updates

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]
    No
    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].
    5/10, the major release

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@j-opatz j-opatz added component: documentation Documentation issue priority: high requestor: METplus Team METplus Development Team labels May 7, 2021
@j-opatz j-opatz added this to the MET 10.0.0 milestone May 7, 2021
@j-opatz j-opatz added this to Pull request review in MET-10.0.0-rc1 (5/10/21) via automation May 7, 2021
@j-opatz j-opatz self-assigned this May 7, 2021
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see suggestions for minor edits.

j-opatz and others added 2 commits May 7, 2021 12:41
Co-authored-by: johnhg <johnhg@ucar.edu>
Co-authored-by: johnhg <johnhg@ucar.edu>
@j-opatz
Copy link
Contributor Author

j-opatz commented May 7, 2021

Comment changes have been approved

Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks John. I approve.

@JohnHalleyGotway JohnHalleyGotway linked an issue May 7, 2021 that may be closed by this pull request
20 tasks
@j-opatz j-opatz merged commit a56f1ee into develop May 7, 2021
MET-10.0.0-rc1 (5/10/21) automation moved this from Pull request review to Done May 7, 2021
@j-opatz j-opatz deleted the feature_1731_docs branch May 7, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update the User's Guide for the 10.0.0 release.
2 participants