Bugfix 1976 main_v10.0 cdist

[JohnHalleyGotway]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [Yes]
  
  If yes, please describe:
  
  Modifies the contents of the CDIST_TRAVELLED column number 36 of the 3D Single Attribute Columns from MTD.

Pull Request Testing

• Describe testing already performed for these changes:
  
  Ran unit_mtd.xml before/after the change.
  BEFORE:

egrep "CDIST|F004" MET_test_output/mtd/mtd_SINGLE_20100517_010000V_3d_single_simple.txt | awk '{print $23, $36}'
OBJECT_ID CDIST_TRAVELLED
F004 417.821

AFTER:

egrep "CDIST|F004" MET_test_output/mtd/mtd_SINGLE_20100517_010000V_3d_single_simple.txt | awk '{print $23, $36}'
OBJECT_ID CDIST_TRAVELLED
F004 147.694

Here's the lat/lon centroid locations:

egrep "VERSION|F004" MET_test_output/mtd/mtd_SINGLE_20100517_010000V_2d.txt | awk '{print $23, $25, $29, $30}'
OBJECT_ID TIME_INDEX CENTROID_LAT CENTROID_LON
F004 0 30.86 -97.45
F004 1 30.90 -97.47 # 5 km
F004 2 30.86 -97.32 # 15 km
F004 3 30.87 -97.30 # 2 km
F004 4 30.80 -96.97 # 32 km
F004 5 30.52 -96.61 # 46 km
F004 6 30.42 -96.30 # 32 km
F004 7 30.48 -96.16 # 15 km

Using NHC's distance calculator to double-check.
Total = 147km... which matches the new output of 147.694 rather than the old output of 417.821.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  No additional testing needed. Please review the code changes to confirm the logic.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
  None needed.

• Do these changes include sufficient testing updates? [Yes]
  None needed.

• Will this PR result in changes to the test suite? [Yes]
  
  If yes, describe the new output and/or changes to the existing output:
  
  Will change the contents of existing MTD output columns.

• Please complete this pull request review by [Monday 11/22/21].
  

Pull Request Checklist

See the METplus Workflow for details.

• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Linked issues with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[CPKalb]

Is there a version of this already compiled somewhere that I could test? It looks like it's doing what it should now.

[JohnHalleyGotway]

@CPKalb I just kicked off a regression test in kiowa:/d1/projects/MET/MET_pull_requests/met-10.1.0/met-10.1.0_beta5/bugfix_1976 to compare the bugfix_1976_develop_cdist branch to develop.

At about 9:00am, you can test the MTD executable in:
/d1/projects/MET/MET_pull_requests/met-10.1.0/met-10.1.0_beta5/bugfix_1976/MET-bugfix_1976_develop_cdist/met/bin/mtd

This is actually the bugfix for the develop branch, but the fix is the same for develop as it is for main_v10.0.

Thanks,
John

[CPKalb]

Great, I'm testing it now.

[CPKalb]

I ran mtd, and the new cdist_travelled works as expected!

[CPKalb]

I ran mtd, and the new cdist_travelled works as expected!