Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 424 roc ctc #427

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Feature 424 roc ctc #427

wants to merge 8 commits into from

Conversation

bikegeek
Copy link
Collaborator

@bikegeek bikegeek commented Mar 26, 2024

Pull Request Testing

  • Describe testing already performed for these changes:
  • Ran all pytests for the ROC diagram
  • Successfully created a ROC diagram using CTC data (reformatted by METdataio):

wind_P500_ctc_ROC

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

generate a ROC diagram using the same data

Instructions:

if running on 'seneca', use this CONDA environment:
/d1/personal/mwin/miniconda3/envs/mp_analysis_env

clone the following code:
- develop branch of METcalcpy
- feature_424_ROC_CTC branch of METplotpy

set up the PYTHONPATH:
- export PYTHONPATH=$CALCPY:$CALCPY/metcalcpy:$PLOTPY:$PLOTPY/metplotpy:$PLOTPY/metplotpy/plots
- $CALCPY and $PLOTPY are env vars pointing to the location of the METcalcpy and METplotpy source, respectively

use this data(remove .txt extension):
This has been reformatted by the METdataio reformatter
wind_only.data.txt

use this custom configuration file (remove .txt extension):
ctc_from_dataio_ROC.yaml.txt

generate the plot:

python $PLOTPY/metplotpy/plots/roc_diagram/roc_diagram.py /path/to/ctc_from_dataio_ROC.yaml

should generate this plot:
wind_P500_ctc_ROC

NOTE:
This is also set up on 'seneca' under:
/d1/personal/mwin/feature_424_ROC_CTC/

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes ]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by anytime before the beta5 release.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek marked this pull request as draft March 26, 2024 18:31
@bikegeek bikegeek requested a review from fisherhucar May 23, 2024 17:01
@bikegeek bikegeek added this to the METplotpy-3.0.0 milestone May 23, 2024
@bikegeek bikegeek linked an issue May 23, 2024 that may be closed by this pull request
22 tasks
@bikegeek bikegeek marked this pull request as ready for review May 23, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

Successfully merging this pull request may close these issues.

ROC diagram support for reformatted CTC linetype input
1 participant