Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with Passenger and Node Cluster module #142

Open
sumpton opened this issue Mar 8, 2019 · 4 comments
Open

Conflict with Passenger and Node Cluster module #142

sumpton opened this issue Mar 8, 2019 · 4 comments

Comments

@sumpton
Copy link

sumpton commented Mar 8, 2019

Passenger is generating an error

You required the Node Cluster module, which is incompatible with Passenger, a non-functional shim was returned and your app may still work. However, please remove the related code as soon as possible.

node_modules/shortid/lib/util/cluster-worker-id.js:3:15

Does anyone know if this is safe to ignore, or of a work around?

@ai
Copy link
Collaborator

ai commented Mar 8, 2019

Do not use ShortID, it is deprecated and unsafe.

Use https://github.com/ai/nanoid/

@sumpton
Copy link
Author

sumpton commented Mar 8, 2019

@ai thank you for helping.

@beppe9000
Copy link

Do not use ShortID, it is deprecated and unsafe.

Use https://github.com/ai/nanoid/

But nanoid is a dependency of this package...

@ai
Copy link
Collaborator

ai commented Dec 2, 2019

@beppe9000 yeap, I as a maintainer of both libraries used Nano ID to solve some problem of short ID with distribution and performance.

But to fix all problems we will need breaking changes in API (dynamic ID length is one of problem). It will be hard to do it, much better just to migrate to Nano ID, which is smaller, safer and faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants