Update hashers.py #216
Open
Update hashers.py #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enhanced the check_password function to handle both synchronous and asynchronous setter functions. If setter is a coroutine function.
Use esmerald utils to check if a function is asynchronous or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling of asynchronous setter functions: You enhanced the function to handle both synchronous and asynchronous setter functions. If setter is a coroutine function (checked using asyncio.iscoroutinefunction(setter)), using asyncio.run(setter(password)) to run it. runs the passed coroutine and returns the result while automatically managing the event loop. This change allows for more flexibility in the setter functions that can be used with check_password.
Direct call for synchronous setter functions: If setter is not a coroutine function, you call it directly as setter(password). This is the same as before, but it's now part of an else clause, executed only when setter is not a coroutine function.