Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set reasonable timeout and disable concurrent builds #5638

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

fredg02
Copy link

@fredg02 fredg02 commented May 3, 2024

Apply Jenkins/CI best practices and avoid builds hanging for days.

@jansupol
Copy link
Contributor

jansupol commented May 3, 2024

@fredg02 Why do we want to disable the concurrent builds? Does it mean that even if we have the available worker, the available worker won't perform the build on another JDK?

@senivam
Copy link
Contributor

senivam commented May 3, 2024

disableConcurrentBuilds() means that if a job is already running (due to a PR for example), another job won't be triggered until the actual job is finished. It can be multithreaded. All workers will be devoted to that actual job run. Other jobs will wait in the queue.

@senivam
Copy link
Contributor

senivam commented May 3, 2024

However, I do not see anything bad if a part of a build in the queue starts before the whole previous build run is finished. This reduces timeout time for waiting in the queue. 30 hours is set because there may be many pushes/pull requests into a branch and all of them are preferable to be processed. If timeout triggers, the last job in the queue will be killed even before it has a chance to be started. Recently I've checked that if the build hung in the queue for some reason (run out of executors for example) it gets aborted even without timeout triggered. And if there are no executors and builds hung, I would prefer to have them in the queue just to notice something is wrong and report an issue to Eclipse. Otherwise, I'm not able to track if all is going well. 30 hours is enough for me to check the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants