Basic editor support for build scripts #585
Conversation
There was a problem hiding this comment.
I gave the editor a second spin and the syntax highlight and the color update works perfectly.
I've found an issue though. It seems that pressing the tab key doesn't work. If the tab character is inserted at the beginning of a line, the characters on the right don't move. The file gets modified though, so only the presentation is broken. Can you please have a look what's going on?
|
Hi Donat,
Thank you very much for your careful testing. That is strange that tab doesn't work.
I think (hope) it shouldn't be too complicated.
I will rest the weekend first :)
Cheers.
…----- Original Message -----
From: Donát Csikós <notifications@github.com>
To: eclipse/buildship <buildship@noreply.github.com>
Cc: Christophe Moine <christophe.moine@free.fr>, Author <author@noreply.github.com>
Sent: Fri, 29 Sep 2017 17:28:27 +0200 (CEST)
Subject: Re: [eclipse/buildship] #514 Add Gradle editor (#585)
donat requested changes on this pull request.
I gave the editor a second spin and the syntax highlight and the color update works perfectly.
I've found an issue though. It seems that pressing the tab key doesn't work. If the tab character is inserted at the beginning of a line, the characters on the right don't move. The file gets modified though, so only the presentation is broken. Can you please have a look what's going on?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#585 (review)
|
|
Sorry, if my previous message sounded a bit pushy. Take your time and let us know if we can help. |
|
Ah, no, I didn't take it that way, no pb :) The method TextSourceViewerConfiguration.getTabWidth was returning zero because of wrong PreferenceStore :) Don't hesitate if you find other problems. Cheers. |
|
I also moved the @author into "Contributor" section in the comment header, because I saw it was like that in other files :) |
|
About the license header: What you found is the old header. If you have a look at the newer source files (like this) then you'll find the proper header. |
There was a problem hiding this comment.
Sorry, but I have to ask one more change. I think it's the same problem as before: when I try to merge your changes I see unrelated commits. Can you please rebase your branch to the latest master?
In case you are interested, here is an article about PRs and rebasing.
|
I think it is because of my mistake when I did a merge with an old branch. I forced a push: I hope it will be much better. |
|
Great ! Ouch, I forgot to replace to @author back. Do you want me to do it ? |
|
Yes, it would be better if you do it :) |
eclipse#560 Add editor contribution + Get rid of the GenericEditor, because it doesn't allow several partition types + Reuse Java syntax color highlighting + Fix tab size in the Gradle editor Signed-off-by: Christophe Moine <christophe.moine@free.fr>
|
It would be a shame to give up at this point :) Done ! |
There was a problem hiding this comment.
Hi @cmoine! I wanted to give the code a final polish but it ended up being a bigger refactoring than I expected. Would you please have a look at my changes and look around if there's something else to simplify?
I'm particularly interested in the common rules in the presentation reconciler and the scanner class.
You can review/merge my code in the PR I've just opened in your repository: cmoine#1
donat
changed the title
donat
changed the title
donat
changed the title
Follows up #564